Maintenance window support by nlamirault · Pull Request #133 · Azure/terraform-azurerm-aks

nlamirault · 2021-12-02T08:49:01Z

This PR add support for https://docs.microsoft.com/en-us/azure/aks/planned-maintenance

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

nlamirault · 2022-01-19T07:26:04Z

@jcorioland Any news for this feature ?

jcorioland · 2022-01-19T07:37:30Z

@nlamirault I am contributor on this project, but I can't review/merge PR, sorry.

nlamirault · 2022-01-19T08:10:17Z

ok @jcorioland .
Project seems not maintained ? Last commit is yours (2021/05/27)

lonegunmanb · 2022-01-24T03:17:30Z

ok @jcorioland . Project seems not maintained ? Last commit is yours (2021/05/27)

Hi @nlamirault , @jcorioland was a contributor and his's pr was accepted and merged by the project's owner.

nlamirault · 2022-03-04T06:47:50Z

Could you review this PR @yupwei68 please ?

lonegunmanb · 2022-04-22T06:43:52Z

Hello @nlamirault , thanks for your pr! I'd like to merge this pr, but now we have conflicts to resolve, and I've left some comments, would you please take a look and push again? Thanks!

lonegunmanb · 2022-04-22T06:34:36Z


+  maintenance_window {
+    dynamic "allowed" {
+      for_each = var.enable_maintenance_window == true ? var.maintenance_allowed : []


Would the following expression be better?

for_each = var.enable_maintenance_window ? var.maintenance_allowed : []

lonegunmanb · 2022-04-22T06:35:24Z

+    }
+
+    dynamic "not_allowed" {
+      for_each = var.enable_maintenance_window == true ? var.maintenance_not_allowed : []


And this line too:

for_each = var.enable_maintenance_window ? var.maintenance_not_allowed : []

lonegunmanb · 2022-04-22T06:42:02Z

+  description = "Days and hours when maintenance is allowed"
+  type = list(object({
+    day = string
+    hours = list(string)


Since the hours is number (doc), would the type list(number) be better?

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

lonegunmanb

Hi, I've tested the code with fixture in the test folder, and the following error occurred:

│ Error: Missing required argument
│
│   with module.aks.azurerm_kubernetes_cluster.main,
│   on ..\..\main.tf line 88, in resource "azurerm_kubernetes_cluster" "main":
│   88:   maintenance_window {
│
│ "maintenance_window.0.allowed": one of `maintenance_window.0.allowed,maintenance_window.0.not_allowed` must be specified
╵
╷
│ Error: Missing required argument
│
│   with module.aks.azurerm_kubernetes_cluster.main,
│   on ..\..\main.tf line 88, in resource "azurerm_kubernetes_cluster" "main":
│   88:   maintenance_window {
│
│ "maintenance_window.0.not_allowed": one of `maintenance_window.0.allowed,maintenance_window.0.not_allowed` must be specified
╵

The enable_maintenance_window default value false will emit an empty maintenance_window block which is not valid. Would the following code be better?:

dynamic "maintenance_window" {
    for_each = var.enable_maintenance_window ? ["maintenance_window"] : []
    content {
      dynamic "allowed" {
        for_each = var.maintenance_allowed
        content {
          day   = allowed.value.day
          hours = allowed.value.hours
        }
      }

      dynamic "not_allowed" {
        for_each = var.maintenance_not_allowed
        content {
          start = not_allowed.value.start
          end   = not_allowed.value.end
        }
      }
    }
  }

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

github-actions · 2022-09-13T03:06:11Z

MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED.

github-actions · 2022-09-13T03:21:57Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED.

github-actions · 2022-09-13T03:22:55Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED.

github-actions · 2022-09-13T03:26:53Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-13T12:10:31Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-14T00:16:23Z

MAIN BRANCH PUSH DETECTED DUE TO #230, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-14T00:32:29Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-14T07:02:14Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-23T06:45:44Z

MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-23T06:48:28Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-23T06:56:03Z

MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-23T23:05:20Z

MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-26T05:04:18Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

zioproto · 2022-09-26T11:09:19Z

@nlamirault this PR does not merge anymore in the current master. Please rebase this work asap or look into the proposed #256

lonegunmanb · 2022-09-27T08:32:27Z

That's ok @zioproto, I'm working on a new pr for this feature, I'll submit it when it's ready.

Btw, in my new pr, I'd like to use optional feature introduced by Terraform 1.3, which requires upgrading on Terraform Core's restriction to >= 1.3. Do you think such a change is a breaking change? If so, I'd like to defer this pr to our next new major release, maybe after we solve all the remaining prs.

github-actions · 2022-09-27T08:41:38Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

zioproto · 2022-09-27T14:58:37Z

Let's keep the discussion in the thread on PR #256

github-actions · 2022-09-28T04:55:50Z

MAIN BRANCH PUSH DETECTED DUE TO #259, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-28T08:26:27Z

MAIN BRANCH PUSH DETECTED DUE TO #262, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-28T14:07:14Z

MAIN BRANCH PUSH DETECTED DUE TO #260, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-29T13:51:23Z

MAIN BRANCH PUSH DETECTED DUE TO #251, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-30T01:27:39Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-30T07:56:00Z

MAIN BRANCH PUSH DETECTED DUE TO #256, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

github-actions · 2022-09-30T07:58:23Z

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

lonegunmanb · 2022-09-30T08:00:24Z

Thanks @nlamirault for open this pr, I'm closing it in favor of #256 has brought us this feature. Thanks for your contribution to this module.

nlamirault · 2022-09-30T10:12:44Z

@lonegunmanb 👍

nlamirault added 3 commits December 2, 2021 09:43

Add: maintenance window support

98f6514

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

Fix: typo

982e74f

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

Fix: maintenance not allowed choice

419382a

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

nlamirault changed the title ~~Add: maintenance window support~~ Maintenance window support Dec 2, 2021

github-actions Bot mentioned this pull request Dec 2, 2021

AKS maintenance windows portefaix/portefaix-kubernetes#1421

Closed

Merge branch 'master' into feat/maintenance_windows

5dcb985

lonegunmanb requested changes May 18, 2022

View reviewed changes

nlamirault added 3 commits May 30, 2022 10:15

Fix: enable or not maintenance window

1cbbd42

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

Fix: duplicate condition

b1fafa1

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

Fix: number variable type

185bcb9

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

lonegunmanb requested changes May 31, 2022

View reviewed changes

lonegunmanb mentioned this pull request May 31, 2022

export addon_profile attributes #151

Merged

nlamirault added 2 commits September 1, 2022 18:23

Merge branch 'master' into feat/maintenance_windows

ef13798

Fix: dynamic block for maintenance window

e26abe3

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

lonegunmanb mentioned this pull request Sep 26, 2022

Support for maintenance_window #255

Closed

1 task

zioproto mentioned this pull request Sep 26, 2022

Add support for maintenance_window #256

Merged

lonegunmanb closed this Sep 30, 2022

Conversation

nlamirault commented Dec 2, 2021

Uh oh!

nlamirault commented Jan 19, 2022

Uh oh!

jcorioland commented Jan 19, 2022

Uh oh!

nlamirault commented Jan 19, 2022

Uh oh!

lonegunmanb commented Jan 24, 2022

Uh oh!

nlamirault commented Mar 4, 2022

Uh oh!

lonegunmanb commented Apr 22, 2022

Uh oh!

lonegunmanb Apr 22, 2022

Choose a reason for hiding this comment

Uh oh!

nlamirault May 30, 2022

Choose a reason for hiding this comment

Uh oh!

lonegunmanb Apr 22, 2022

Choose a reason for hiding this comment

Uh oh!

nlamirault May 30, 2022

Choose a reason for hiding this comment

Uh oh!

lonegunmanb Apr 22, 2022

Choose a reason for hiding this comment

Uh oh!

nlamirault May 30, 2022

Choose a reason for hiding this comment

Uh oh!

lonegunmanb left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 13, 2022

Uh oh!

github-actions Bot commented Sep 13, 2022

Uh oh!

github-actions Bot commented Sep 13, 2022

Uh oh!

github-actions Bot commented Sep 13, 2022

Uh oh!

github-actions Bot commented Sep 13, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 23, 2022

Uh oh!

github-actions Bot commented Sep 23, 2022

Uh oh!

github-actions Bot commented Sep 23, 2022

Uh oh!

github-actions Bot commented Sep 23, 2022

Uh oh!

github-actions Bot commented Sep 26, 2022

Uh oh!

zioproto commented Sep 26, 2022

Uh oh!

lonegunmanb commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 27, 2022

Uh oh!

zioproto commented Sep 27, 2022

Uh oh!

github-actions Bot commented Sep 28, 2022

Uh oh!

github-actions Bot commented Sep 28, 2022

Uh oh!

github-actions Bot commented Sep 28, 2022

Uh oh!

github-actions Bot commented Sep 29, 2022

Uh oh!

github-actions Bot commented Sep 30, 2022

lonegunmanb commented Sep 27, 2022 •

edited

Loading