Skip to content

Update azurerm provider's restriction.#248

Merged
lonegunmanb merged 2 commits intoAzure:masterfrom
lonegunmanb:limit-example-provider-version
Sep 30, 2022
Merged

Update azurerm provider's restriction.#248
lonegunmanb merged 2 commits intoAzure:masterfrom
lonegunmanb:limit-example-provider-version

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb commented Sep 14, 2022 •
edited
Loading

Limit azurerm provider's version since enforce_private_link_endpoint_network_policies in azurerm_subnet will be removed in 4.x.
This pr also loosen the azurerm provider's restriction.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb force-pushed the limit-example-provider-version branch from c1caa5d to 818f7f4 Compare September 15, 2022 02:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2022

MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb force-pushed the limit-example-provider-version branch from 818f7f4 to 44a4cca Compare September 23, 2022 06:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2022

MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2022

MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 26, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 27, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 28, 2022

MAIN BRANCH PUSH DETECTED DUE TO #259, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 28, 2022

MAIN BRANCH PUSH DETECTED DUE TO #262, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 28, 2022

MAIN BRANCH PUSH DETECTED DUE TO #260, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 29, 2022

MAIN BRANCH PUSH DETECTED DUE TO #251, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb
Limit azurerm provider's version since `enforce_private_link_endpoint…
0181d40 
…_network_policies` in `azurerm_subnet` will be removed in 4.x.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 30, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb force-pushed the limit-example-provider-version branch from 44a4cca to 0181d40 Compare September 30, 2022 01:27
@lonegunmanb lonegunmanb temporarily deployed to acctests September 30, 2022 01:39 Inactive
@lonegunmanb lonegunmanb changed the title Limit azurerm provider's version in example code Update azurerm provider's restriction. Sep 30, 2022
@lonegunmanb lonegunmanb temporarily deployed to acctests September 30, 2022 07:54 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 30, 2022

MAIN BRANCH PUSH DETECTED DUE TO #256, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 30, 2022

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@zioproto
Copy link
Copy Markdown
Contributor

zioproto commented Sep 30, 2022

I tested the following:

 module "aks" {
-  source                            = "Azure/aks/azurerm"
+  source                            = "git::https://github.com/lonegunmanb/terraform-azurerm-aks.git?ref=limit-example-provider-version"
[....]

The terraform init -upgrade works. LGTM

@lonegunmanb lonegunmanb merged commit 772b452 into Azure:master Sep 30, 2022
@lonegunmanb lonegunmanb deleted the limit-example-provider-version branch September 30, 2022 10:49
This was referenced Sep 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zioproto zioproto zioproto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lonegunmanb @zioproto
⚡