test for infinite loop in combineWays() / rewrite combineWays#96
Merged
Beakerboy merged 2 commits intoBeakerboy:mainfrom Apr 29, 2025
Merged
test for infinite loop in combineWays() / rewrite combineWays#96Beakerboy merged 2 commits intoBeakerboy:mainfrom
Beakerboy merged 2 commits intoBeakerboy:mainfrom
Conversation
deevroman
changed the title
Owner
|
Thank you so much! |
Owner
|
Do you think it’s worthwhile passing on a message to the errorBox when the combineWays function has leftover unused ways after ring formation. It seems this should indicate malformed data. |
Contributor
Author
|
I think so. I can't think of a case where this might be correct. |
Owner
|
@deevroman, I added a check to remove any self intersecting ways from the array of ways before they pass into the ring creation algorithm. Would you be able to look into inspecting completed rings, and discard if they are self intersecting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testTimeoutdoesn't work in this case.combineWays()gets stuck.Second commit: new combineWays() from #84
fix for #83