Conversation
Fixed GUI color map update (HACK)
|
yes looks a lot like a hack, let me give it a shot, I'm afraid this will break something in the resize mechanism |
|
@aashish24 please do NOT self approve this is the wrong way to fix this. How do you go at unmerging? |
|
@doutriaux1 this is how fixed it. Its not my fix per say. |
|
@doutriaux1 don't revert this commit. This works and this is what you had in your other commit. I tested it and it works with other fix we did. |
|
ithink this was not for colormap but interaction, the colormap fix was by calling "update" after setcolormap. I will push a branch in a minute. I might put this line back in if really needed. |
|
it was for the color map. Accroding to you note in the configureEvent, the GUI only handles the resize event and this change was required for that. Just callign update fixes the VCS but not the GUI. @dlonie looked into it quite a bit and so did I. There is a test for it as well. test_vcs_color I believe. |
|
ok i'm looking into it again. Sorry it was before the vacation, and I'd rather spend an extra 2 hours on this rather than pushing sometihng wrong. |
|
better safe than sorry. |
|
Go ahead.. 👍 |
2 participants
@doutriaux1 @dlonie please approve