Revert "Fixed GUI color map update (HACK)"#746
Merged
doutriaux1 merged 1 commit intomasterfrom Oct 6, 2014
Merged
Conversation
doutriaux1
added a commit
that referenced
this pull request
Oct 6, 2014
…ate_hack Revert "Fixed GUI color map update (HACK)"
Contributor
|
@doutriaux1 this is your fix really. If you think you can fix the GUI in some other way, then reverting this is fine. I tested after making this change and with other change David made, it worked fine (all tests were passing) and the GUI worked. |
Contributor
Author
|
i think that wwas for fixing the interaction issues, not the colormap. Let me push another branch |
Contributor
|
Please look at the test_vcs_color test. Again, I have looked into the code quite a bit. the _lastSize = -1 was for the GUI. Calling update was the vcs command line to work for the color map change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #744. Let's wait until somebdy that is NOT the autohr reviews and merges. I think there is a better way to fix this.