Revert "[Analyzer] Add analyzer for conflicting [ID] attribute usage#9841
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the recently added Roslyn analyzer that detected conflicting [ID] attribute usages, because the analyzer did not correctly account for input object types and there isn’t a reliable way to determine input vs output at analysis time.
Changes:
- Removes
ConflictingIdAttributeAnalyzerfrom the analyzer set executed in the analyzer test harness. - Deletes the
ConflictingIdAttributeAnalyzerimplementation and its associatedHC0115diagnostic/resource entries. - Removes the analyzer’s unit tests and all related snapshot files.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/test/Types.Analyzers.Tests/TestHelper.cs | Stops executing the reverted analyzer in analyzer-enabled test runs. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/ConflictingIdAttributeAnalyzerTests.cs | Removes tests that were specific to the reverted analyzer. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ConflictingIdAttributeAnalyzerTests.*.md | Removes snapshot baselines generated for the reverted analyzer diagnostics. |
| src/HotChocolate/Core/src/Types.Analyzers/WellKnownAttributes.cs | Removes IDAttribute well-known attribute constants that were only needed by the reverted analyzer. |
| src/HotChocolate/Core/src/Types.Analyzers/Properties/SourceGenResources.resx | Removes the ConflictingIdAttribute resource string used by HC0115. |
| src/HotChocolate/Core/src/Types.Analyzers/Properties/SourceGenResources.Designer.cs | Removes the generated strongly-typed accessor for the deleted resource. |
| src/HotChocolate/Core/src/Types.Analyzers/Errors.cs | Removes the HC0115 diagnostic descriptor definition. |
| src/HotChocolate/Core/src/Types.Analyzers/ConflictingIdAttributeAnalyzer.cs | Deletes the analyzer implementation being reverted. |
Files not reviewed (1)
- src/HotChocolate/Core/src/Types.Analyzers/Properties/SourceGenResources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't account for input object types when building the analyzer. Since there's no reliable way to tell if something will become an input or not, I'll revert the analyzer for now.
This reverts commit f9e257a.