Skip to content

Revert "[Analyzer] Add analyzer for conflicting [ID] attribute usage #9841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias-tengler merged 1 commit into from
Jun 4, 2026
Merged

Revert "[Analyzer] Add analyzer for conflicting [ID] attribute usage #9841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
224 changes: 0 additions & 224 deletions src/HotChocolate/Core/src/Types.Analyzers/ConflictingIdAttributeAnalyzer.cs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/HotChocolate/Core/src/Types.Analyzers/Errors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,4 @@ public static class Errors
category: "TypeSystem",
DiagnosticSeverity.Error,
isEnabledByDefault: true);

public static readonly DiagnosticDescriptor ConflictingIdAttribute =
new(
id: "HC0115",
title: "Conflicting [ID] attribute ID types",
messageFormat: SourceGenResources.ConflictingIdAttribute,
category: "TypeSystem",
DiagnosticSeverity.Error,
isEnabledByDefault: true);
}
9 changes: 0 additions & 9 deletions src/HotChocolate/Core/src/Types.Analyzers/Properties/SourceGenResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/HotChocolate/Core/src/Types.Analyzers/Properties/SourceGenResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
<data name="DataLoader_KeyParameterMissing" xml:space="preserve">
<value>A DataLoader must at least provides a key or keys parameter</value>
</data>
<data name="ConflictingIdAttribute" xml:space="preserve">
<value>The [ID] attribute on '{0}' maps to the same ID type name as '{1}', but their ID value types differ. An ID type name can only bind to a single value type, so change '{0}' to use the same type as '{1}' ('{2}'), or give it a different type name with [ID&lt;T&gt;] or [ID("TypeName")].</value>
</data>
<data name="DataLoader_InvalidAccessModifier" xml:space="preserve">
<value>The DataLoader access modifier must be public or internal</value>
</data>
Expand Down
2 changes: 0 additions & 2 deletions src/HotChocolate/Core/src/Types.Analyzers/WellKnownAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ public static class WellKnownAttributes
public const string SubscriptionAttribute = "HotChocolate.SubscriptionAttribute";
public const string SubscribeAttribute = "HotChocolate.Types.SubscribeAttribute";
public const string NodeResolverAttribute = "HotChocolate.Types.Relay.NodeResolverAttribute";
public const string IdAttribute = "HotChocolate.Types.Relay.IDAttribute";
public const string GenericIdAttribute = "HotChocolate.Types.Relay.IDAttribute`1";
public const string ParentAttribute = "HotChocolate.ParentAttribute";
public const string EventMessageAttribute = "HotChocolate.EventMessageAttribute";
public const string ServiceAttribute = "HotChocolate.ServiceAttribute";
Expand Down
Loading
Loading
⚡