Merged
Conversation
Minion3665
force-pushed
the
private/skyler/push-kymynspnkvno
branch
from
141dea6 to
c0e8f5c
Compare
On the edit button in the mobile view, the pencil icon has been off-center for a little while. To prevent that from happening again, we can can center it using flex rather than providing a fixed margin and position Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: Ie080a740ca8927d47be3c3bb444bea79043cb575
Minion3665
force-pushed
the
private/skyler/push-kymynspnkvno
branch
from
c0e8f5c to
a99b9d9
Compare
eszkadev
approved these changes
Apr 25, 2025
Contributor
eszkadev
left a comment
eszkadev
left a comment
There was a problem hiding this comment.
yes, goot to avoid direct pixel positions, thanks
it would be nice to have it also as a separate control in separate file...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the edit button in the mobile view, the pencil icon has been off-center for a little while. To prevent that from happening again, we can can center it using flex rather than providing a fixed margin and position
Change-Id: Ie080a740ca8927d47be3c3bb444bea79043cb575
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay