Merged
Conversation
… tab This fixes the regression of eb6bbe5 caused by introduction of overflow group popup, which created a conflicting overflow group id with home search button for Writer, Calc and Draw notebook bar Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I138fdbb197585f9c3af95d681570952b7a028b2b
Changes: 1. This reverts the commit 5fccafd 2. Introduces more simplified fix which focuses on creating accessibility definitions with correct element id exist in DOM Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I9ed3ad0ca3f90665efc68014111263deece583fc
- Add new shortcut 'VM' to open the view mode dropdown using accelerator Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I3e29b4a1f38ebffd75b0c8299357f6b398d7b5b4
Merged
caolanm
reviewed
Feb 25, 2026
eszkadev
requested changes
Feb 25, 2026
Contributor
eszkadev
left a comment
eszkadev
left a comment
There was a problem hiding this comment.
with this PR I no longer can open accelerators in Calc:
Uncaught TypeError: Cannot read properties of null (reading 'accessKey')
at NotebookbarAccessibilityDefinitions.targetedButtonsForTab (NotebookbarAccessibilityDefinitions.js:184:15)
at NotebookbarAccessibilityDefinitions.getTabsAndContents (NotebookbarAccessibilityDefinitions.js:104:10)
at NotebookbarAccessibilityDefinitions.getDefinitions (NotebookbarAccessibilityDefinitions.js:190:34)
at NotebookbarAccessibility.<anonymous> (
github-project-automation
Bot
moved this from To Review
to In Progress
in Collabora Online
…utton - This fixes the regression caused by e2538b1 - removed existing json data which also contains the accessibility shortcut. Change-Id: I47102aa114f0e4d9f1b12b89b9371670908e9cb4 Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com>
rparth07
force-pushed
the
private/rparth07/accessibility-shortcut-fix
branch
from
da62fff to
e535d5f
Compare
eszkadev
reviewed
Feb 25, 2026
| @@ -1000,7 +1000,7 @@ window.L.Control.NotebookbarWriter = window.L.Control.Notebookbar.extend({ | |||
| { type: 'separator', id: 'home-charmapcontrol-break', orientation: 'vertical' }, | |||
| { | |||
| 'type': 'overflowgroup', | |||
| 'id': 'home-search', | |||
| 'id': 'home-find-n-filter', | |||
Contributor
There was a problem hiding this comment.
are we sure it doesn't break any styling?
cc @pedropintosilva
github-project-automation
Bot
moved this from In Progress
to To Test
in Collabora Online
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay