upgrade to Puppet 8 and PDK version to 3.4#823
Merged
fanny-jiang merged 155 commits intoDataDog:mainfrom Mar 10, 2025
Merged
Conversation
added 7 commits
December 20, 2024 15:35
…ve legacy :: referencing. Changes for Puppet 8
… prettied the code.
…g no check for empty strings
… bcrypt_pbkdf 1.1 fails to install with Ruby 3.2.5
xenon8
changed the title
xenon8
commented
Jan 27, 2025
nielstholenaar
suggested changes
Jan 27, 2025
Contributor
nielstholenaar
left a comment
nielstholenaar
left a comment
There was a problem hiding this comment.
Thanks for all the work on the Puppet 8 version.
I'm currently in the process of upgrading our Puppet server and this module was one of the modules that lacked support. I have added some fixes for things I experienced while using your version.
added 4 commits
January 27, 2025 15:30
This was referenced Jan 28, 2025
nielstholenaar
suggested changes
Jan 28, 2025
Clean up legacy Agent 5 code
…uppet-datadog-agent into xenon8/puppet-8-upgrade
Address linter warnings
add back redis ssl
…uppet-datadog-agent into xenon8/puppet-8-upgrade
Fix postgres and elastic, agent 5 cleanups
rtrieu
requested changes
Mar 10, 2025
Contributor
rtrieu
left a comment
rtrieu
left a comment
There was a problem hiding this comment.
Left some feedback for your review!
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
This was referenced Apr 15, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update the Puppet syntax for module to v8 of Puppet; I have updated the reference to StdLib to v9 as well (as this is the version that supports Puppet 8).
I used the PDK for this update; resulting me updating the PDK files also, I had to merge your existing code into the PDK 3.4 template, please let me know if I missed something.