tcp_check requires parameters as mandatory since 4.0.0 that should not be mandatory

[johannesschillinger-dm]

Hi Datadog Team,

in Commit 12db4ae the tcp_check.pp was modified to now require multiple parameters as mandatory that were not mandatory before:

String $check_name, String $host, String $port,
see

puppet-datadog-agent/manifests/integrations/tcp_check.pp

Line 84 in f268291

String $check_name,

There is no explanation given in the CHANGELOG and I think this was done by mistake. As the $instances parameter allows to specify multiple instances of the TCP check instead of just a single one, it should rather be checked if

• the three paramters are given
• and if not: is the instances parameter correctly populated

Regards
Johannes

[fanny-jiang]

Hi @johannesschillinger-dm, thanks for the report. Indeed, it looks like we've overlooked properly handling the instances option. We'll get this fixed.