Fixes #1284 - JavaFX25 introduced getCaretShape to replace caretShape to fix#1285
Conversation
…s with the method in TextFlowExt
Jugen
left a comment
There was a problem hiding this comment.
Please also change hitTest which has been deprecated as well, to getHitInfo :
|
@Jugen for your comment about |
|
Removing getCaretShape is unnecessary then as it overrides the one in TextFlow. |
|
You are right about that, I didn't test the compilation on Java 25 and I assume the error from the comment was correct, but I don't see a final here. That being said, I don't think there is any urge to merge this PR, so I'll let you decide what you want to do. I'm ready to modify it if you have any preference. |
|
I'll give it some thought, however I'm currently inclined to leave it as is. |
Fixes #1284 - My only concern with this change is that by removing the method, if someone extended
TextFlowExtand used the method, it will suddenly hit the one from JavaFX 25 which is slightly different.That being said, there is no real fix for that, as JavaFX 25 will not go away.