Skip to content

Implement kernel.reset support for Elastica services#1985

Open
igor-kuzmanovic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
igor-kuzmanovic:fix-1984
Open

Implement kernel.reset support for Elastica services#1985
igor-kuzmanovic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
igor-kuzmanovic:fix-1984

Conversation

@igor-kuzmanovic
Copy link
Copy Markdown

Fixes #1984

Make ElasticaLogger implement ResetInterface and tag it with kernel.reset tag.
Tag the Client definition with kernel.reset tag (already implements ResetInterface).
Tag ElasticaDataCollector with kernel.reset tag (already implements ResetInterface through DataCollectorInterface).

It seems implementing ResetInterface is optional and is only used for autoconfiguration which doesn't matter in a third party bundle but just for the sake of being explicit.

$container->registerForAutoconfiguration(ResetInterface::class)
            ->addTag('kernel.reset', ['method' => 'reset']);

- Make ElasticaLogger implement ResetInterface
- Tag ElasticaLogger, ElasticaDataCollector and Client with kernel.reset

Fixes FriendsOfSymfony#1984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElasticaLogger Memory Leak

1 participant