Implement kernel.reset support for Elastica services#1985
Open
igor-kuzmanovic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
Open
Implement kernel.reset support for Elastica services#1985igor-kuzmanovic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
igor-kuzmanovic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
Conversation
- Make ElasticaLogger implement ResetInterface - Tag ElasticaLogger, ElasticaDataCollector and Client with kernel.reset Fixes FriendsOfSymfony#1984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1984
Make
ElasticaLoggerimplementResetInterfaceand tag it withkernel.resettag.Tag the
Clientdefinition withkernel.resettag (already implementsResetInterface).Tag
ElasticaDataCollectorwithkernel.resettag (already implementsResetInterfacethroughDataCollectorInterface).It seems implementing
ResetInterfaceis optional and is only used for autoconfiguration which doesn't matter in a third party bundle but just for the sake of being explicit.