Skip to content

Implement kernel.reset support for Elastica services #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igor-kuzmanovic wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Implement kernel.reset support for Elastica services #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DependencyInjection/FOSElasticaExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ private function loadClients(array $clients, ContainerBuilder $container): void
}

$clientDef->addTag('fos_elastica.client');
$clientDef->addTag('kernel.reset', ['method' => 'reset']);

$container->setDefinition($clientId, $clientDef);
$container->registerAliasForArgument($clientId, Client::class, $name.'.client');
Expand Down
3 changes: 2 additions & 1 deletion src/Logger/ElasticaLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use Psr\Log\AbstractLogger;
use Psr\Log\LoggerInterface;
use Symfony\Contracts\Service\ResetInterface;

/**
* Logger for the Elastica.
Expand All @@ -22,7 +23,7 @@
*
* @author Gordon Franke <info@nevalon.de>
*/
class ElasticaLogger extends AbstractLogger
class ElasticaLogger extends AbstractLogger implements ResetInterface
{
protected ?LoggerInterface $logger;
/**
Expand Down
2 changes: 2 additions & 0 deletions src/Resources/config/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<service id="fos_elastica.data_collector" class="FOS\ElasticaBundle\DataCollector\ElasticaDataCollector">
<tag name="data_collector" template="@FOSElastica/Collector/elastica.html.twig" id="elastica" />
<argument type="service" id="fos_elastica.logger" />
<tag name="kernel.reset" method="reset" />
</service>

<service id="fos_elastica.paginator.subscriber" class="FOS\ElasticaBundle\Subscriber\PaginateElasticaQuerySubscriber">
Expand All @@ -54,6 +55,7 @@
<argument type="service" id="logger" on-invalid="null" />
<argument>%kernel.debug%</argument>
<tag name="monolog.logger" channel="elastica" />
<tag name="kernel.reset" method="reset" />
</service>

<service id="fos_elastica.mapping_builder" class="FOS\ElasticaBundle\Index\MappingBuilder">
Expand Down
Loading
⚡