virtual-servers-select-all-count#3849
Merged
crivetimihai merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
Nayana-R-Gowda
added
bug
Signed-off-by: NAYANA.R <nayana.r7813@gmail.com>
Signed-off-by: NAYANA.R <nayana.r7813@gmail.com>
…Select functions Extend the Select All button count fix from initToolSelect to initResourceSelect, initPromptSelect, and initGatewaySelect for consistency. Remove stale originalText + setTimeout pattern from all three sibling functions. Update Playwright assertions to match new button text format and add JS unit tests for count display behavior. Closes #3833 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
fix/virtual-servers-select-all-count
branch
from
441b3d5 to
d015a00
Compare
Member
Review & ChangesRebased onto Changes made during reviewConsistency fix: The original PR only applied the count display fix to
For each: added Tests updated:
All 989 JS tests pass. No security or performance concerns. |
crivetimihai
approved these changes
Mar 26, 2026
Member
crivetimihai
left a comment
crivetimihai
left a comment
There was a problem hiding this comment.
LGTM — fix is correct and now consistent across all four init*Select functions. Tests added.
brian-hussey
pushed a commit
that referenced
this pull request
Mar 27, 2026
* virtual-servers-select-all-count Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> * remove unused originalText variable in select all handler Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> * fix(ui): apply Select All count display consistently across all init*Select functions Extend the Select All button count fix from initToolSelect to initResourceSelect, initPromptSelect, and initGatewaySelect for consistency. Remove stale originalText + setTimeout pattern from all three sibling functions. Update Playwright assertions to match new button text format and add JS unit tests for count display behavior. Closes #3833 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
madhu-mohan-jaishankar
pushed a commit
that referenced
this pull request
Mar 27, 2026
* virtual-servers-select-all-count Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> * remove unused originalText variable in select all handler Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> * fix(ui): apply Select All count display consistently across all init*Select functions Extend the Select All button count fix from initToolSelect to initResourceSelect, initPromptSelect, and initGatewaySelect for consistency. Remove stale originalText + setTimeout pattern from all three sibling functions. Update Playwright assertions to match new button text format and add JS unit tests for count display behavior. Closes #3833 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANA.R nayana.r7813@gmail.com
closes #3833
💡 Fix Description
It re-fetches the button using document.getElementById to avoid stale references.
If the button exists:
When count > 0 → updates text to Select All (count)
When count === 0 → resets text to Select All
🧪 Verification
make lintmake test📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)