Skip to content

virtual-servers-select-all-count #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crivetimihai merged 3 commits into from
Mar 26, 2026
+341 āˆ’38
Merged

virtual-servers-select-all-count #3849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56b4c9d
virtual-servers-select-all-count
Nayana-R-Gowda Mar 25, 2026
eb26bb6
remove unused originalText variable in select all handler
Nayana-R-Gowda Mar 25, 2026
d015a00
fix(ui): apply Select All count display consistently across all init*ā€¦
crivetimihai Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 55 additions & 26 deletions mcpgateway/static/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9880,6 +9880,19 @@ function initToolSelect(
} else {
warnBox.textContent = "";
}

// Update the Select All button text to show count
// Re-query the button by ID to ensure we get the current button (not a stale reference)
if (selectBtnId) {
const currentSelectBtn = document.getElementById(selectBtnId);
if (currentSelectBtn) {
if (count > 0) {
currentSelectBtn.textContent = `Select All (${count})`;
} else {
currentSelectBtn.textContent = "Select All";
}
}
}
} catch (error) {
console.error("Error updating tool select:", error);
}
Expand Down Expand Up @@ -9927,7 +9940,6 @@ function initToolSelect(

newSelectBtn.addEventListener("click", async () => {
// Disable button and show loading state
const originalText = newSelectBtn.textContent;
newSelectBtn.disabled = true;
newSelectBtn.textContent = "Selecting all tools...";

Expand Down Expand Up @@ -10010,16 +10022,11 @@ function initToolSelect(
allToolIds.forEach((id) => editSel.add(String(id)));

update();

newSelectBtn.textContent = `āœ“ All ${allToolIds.length} tools selected`;
setTimeout(() => {
newSelectBtn.textContent = originalText;
}, 2000);
} catch (error) {
console.error("Error in Select All:", error);
alert("Failed to select all tools. Please try again.");
newSelectBtn.disabled = false;
newSelectBtn.textContent = originalText;
update(); // Reset button text via update()
} finally {
newSelectBtn.disabled = false;
}
Expand Down Expand Up @@ -10309,6 +10316,18 @@ function initResourceSelect(
} else {
warnBox.textContent = "";
}

// Update the Select All button text to show count
if (selectBtnId) {
const currentSelectBtn = document.getElementById(selectBtnId);
if (currentSelectBtn) {
if (count > 0) {
currentSelectBtn.textContent = `Select All (${count})`;
} else {
currentSelectBtn.textContent = "Select All";
}
}
}
} catch (error) {
console.error("Error updating resource select:", error);
}
Expand Down Expand Up @@ -10355,7 +10374,6 @@ function initResourceSelect(
selectBtn.parentNode.replaceChild(newSelectBtn, selectBtn);

newSelectBtn.addEventListener("click", async () => {
const originalText = newSelectBtn.textContent;
newSelectBtn.disabled = true;
newSelectBtn.textContent = "Selecting all resources...";

Expand Down Expand Up @@ -10438,14 +10456,11 @@ function initResourceSelect(
allIds.forEach((id) => editSel.add(String(id)));

update();

newSelectBtn.textContent = `āœ“ All ${allIds.length} resources selected`;
setTimeout(() => {
newSelectBtn.textContent = originalText;
}, 2000);
} catch (error) {
console.error("Error selecting all resources:", error);
alert("Failed to select all resources. Please try again.");
newSelectBtn.disabled = false;
update(); // Reset button text via update()
} finally {
newSelectBtn.disabled = false;
}
Expand Down Expand Up @@ -10724,6 +10739,18 @@ function initPromptSelect(
} else {
warnBox.textContent = "";
}

// Update the Select All button text to show count
if (selectBtnId) {
const currentSelectBtn = document.getElementById(selectBtnId);
if (currentSelectBtn) {
if (count > 0) {
currentSelectBtn.textContent = `Select All (${count})`;
} else {
currentSelectBtn.textContent = "Select All";
}
}
}
} catch (error) {
console.error("Error updating prompt select:", error);
}
Expand Down Expand Up @@ -10769,7 +10796,6 @@ function initPromptSelect(
newSelectBtn.dataset.listenerAttached = "true";
selectBtn.parentNode.replaceChild(newSelectBtn, selectBtn);
newSelectBtn.addEventListener("click", async () => {
const originalText = newSelectBtn.textContent;
newSelectBtn.disabled = true;
newSelectBtn.textContent = "Selecting all prompts...";

Expand Down Expand Up @@ -10852,14 +10878,11 @@ function initPromptSelect(
allIds.forEach((id) => editSel.add(String(id)));

update();

newSelectBtn.textContent = `āœ“ All ${allIds.length} prompts selected`;
setTimeout(() => {
newSelectBtn.textContent = originalText;
}, 2000);
} catch (error) {
console.error("Error selecting all prompts:", error);
alert("Failed to select all prompts. Please try again.");
newSelectBtn.disabled = false;
update(); // Reset button text via update()
} finally {
newSelectBtn.disabled = false;
}
Expand Down Expand Up @@ -11118,6 +11141,18 @@ function initGatewaySelect(
} else {
warnBox.textContent = "";
}

// Update the Select All button text to show count
if (selectBtnId) {
const currentSelectBtn = document.getElementById(selectBtnId);
if (currentSelectBtn) {
if (count > 0) {
currentSelectBtn.textContent = `Select All (${count})`;
} else {
currentSelectBtn.textContent = "Select All";
}
}
}
} catch (error) {
console.error("Error updating gateway select:", error);
}
Expand Down Expand Up @@ -11165,7 +11200,6 @@ function initGatewaySelect(

newSelectBtn.addEventListener("click", async () => {
// Disable button and show loading state
const originalText = newSelectBtn.textContent;
newSelectBtn.disabled = true;
newSelectBtn.textContent = "Selecting all gateways...";

Expand Down Expand Up @@ -11258,18 +11292,13 @@ function initGatewaySelect(

update();

newSelectBtn.textContent = `āœ“ All ${allGatewayIds.length} gateways selected`;
setTimeout(() => {
newSelectBtn.textContent = originalText;
}, 2000);

// Reload associated items after selecting all
reloadAssociatedItems();
} catch (error) {
console.error("Error in Select All:", error);
alert("Failed to select all gateways. Please try again.");
newSelectBtn.disabled = false;
newSelectBtn.textContent = originalText;
update(); // Reset button text via update()
} finally {
newSelectBtn.disabled = false;
}
Expand Down
Loading
Loading
āš”