Addition to IQSS/11391 display on create with template#11539
Merged
ofahimIQSS merged 3 commits intoIQSS:developfrom Jun 4, 2025
Merged
Conversation
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
sekmiller
reviewed
Jun 3, 2025
sekmiller
requested changes
Jun 3, 2025
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good overall. I think we can do one more tiny bit of simplification.
sekmiller
approved these changes
Jun 4, 2025
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good. thanks for the update
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
tested in internal with displayoncreate set to true. Looks good from my end - merging. |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
During review of #11391, I made some suggestions in a PR against that PR that didn't get merged before the main PR went through QA. This PR includes those changes. They shouldn't change functionality:
The change in DatasetField is just a refactor to remove duplicate code per https://github.com/IQSS/dataverse/pull/11411/files#r2072692564
The second change (DatasetVersionUI, MetadataBlock) is just some cleanup after figuring out why shouldDisplayOnCreate in MetadataBlock wasn't working re: discussion in https://github.com/IQSS/dataverse/pull/11411/files#r2072686331.
Which issue(s) this PR closes:
Special notes for your reviewer: #11538 has some additional comments on the code to explain the changes.
Suggestions on how to test this: Veriify the test scenarios in #11391 still work (FWIW: I did those tests and this seems to work).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: