Skip to content

fix file downloadSize/Count after revert#11702

Merged
ofahimIQSS merged 3 commits intodevelopfrom
11465-api-fetch-download-size-file-count-2
Aug 6, 2025
Merged

fix file downloadSize/Count after revert#11702
ofahimIQSS merged 3 commits intodevelopfrom
11465-api-fetch-download-size-file-count-2

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

What this PR does / why we need it: fix after revert. guest user should see deaccessioned file count and download size

Which issue(s) this PR closes:#11465

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this Jul 30, 2025
@github-actions github-actions Bot added FY24 Sprint 23 FY24 Sprint 23 FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA Type: Bug a defect labels Jul 30, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Jul 30, 2025
@stevenwinship stevenwinship changed the title fix after revert fix file downloadSize/Count after revert Jul 30, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 30, 2025

Coverage Status

coverage: 23.23%. remained the same
when pulling 4947496 on 11465-api-fetch-download-size-file-count-2
into b446904 on develop.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship added Size: 3 A percentage of a sprint. 2.1 hours. and removed Size: 10 A percentage of a sprint. 7 hours. labels Jul 30, 2025
@cmbz cmbz added the FY26 Sprint 3 (2025-07-30 - 2025-08-13) label Jul 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11465-api-fetch-download-size-file-count-2
ghcr.io/gdcc/configbaker:11465-api-fetch-download-size-file-count-2

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship removed their assignment Aug 1, 2025
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Aug 1, 2025
@sekmiller sekmiller self-assigned this Aug 6, 2025
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Aug 6, 2025
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As I mentioned in Standup I will put in a ticket suggesting the removal of the bypassAccessCheck boolean from getDatasetVersionOrDie.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Aug 6, 2025
@sekmiller sekmiller removed their assignment Aug 6, 2025
@ofahimIQSS ofahimIQSS self-assigned this Aug 6, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Aug 6, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

good stuff, merging.
image

@ofahimIQSS ofahimIQSS merged commit 04ad1a6 into develop Aug 6, 2025
22 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Aug 6, 2025
@ofahimIQSS ofahimIQSS deleted the 11465-api-fetch-download-size-file-count-2 branch August 6, 2025 16:43
@ofahimIQSS ofahimIQSS removed their assignment Aug 6, 2025
@pdurbin pdurbin added this to the 6.8 milestone Aug 6, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Aug 7, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY24 Sprint 23 FY24 Sprint 23 FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 3 (2025-07-30 - 2025-08-13) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

File API: fetch file downloadSize/count if a deaccessioned dataset has no file

7 participants