Bug: block guest from calling api#11636
Merged
ofahimIQSS merged 6 commits intodevelopfrom Jul 21, 2025
Merged
Conversation
github-actions
Bot
added
FY24 Sprint 23
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
sekmiller
approved these changes
Jul 16, 2025
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good. Passing to QA
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
fix looks good- merging |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Member
|
@stevenwinship - I didn't think the idea was to block all guest access to these endpoints for any version, but to return a 403 (instead of 404, etc.) when a user is asking about versions they don't have access to (draft or deaccessioned). |
Member
|
@qqmyers yes, good call. At standup we agreed to revert this PR. Here's the PR to revert it: |
ofahimIQSS
added a commit
that referenced
this pull request
Jul 30, 2025
…load-size-file-count Revert #11636 "Bug: block guest from calling api"
Member
|
Now that the newer, better post-revert PR has been merged: ... I'd say it's save to move this from "ready for triage" to "done". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: /datasets/:persistentId/versions/:latest-published/downloadsize and /api/v1/datasets/:persistentId/versions/1.0/files/counts returning 200 or 404 for guest users instead of 403
Which issue(s) this PR closes:#11465
Special notes for your reviewer: API is for Authenticated Users only
Suggestions on how to test this: See IT tests
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: