refactor!: top-level script "qtl" for running all timeline code#301
Merged
refactor!: top-level script "qtl" for running all timeline code#301
qtl" for running all timeline code#301Conversation
timeline is way to common of a name for the top-level binary
might as well do it now, especially since chefs only have to run one script now
thyme" for running all timeline codeqtl" for running all timeline code
be more consistent with workflow step: require only one output-type argument (`-p`)
…n there are warnings we'll catch the problems in production; hopefully we'll do this better when we refactor physics timelines...
- if before RG-L, don't even run the timeline engine - if during RG-L, run the engine, but if data are empty, don't attempt to produce the final timeline and instead complain to `stderr` so the chef sees the issue Fixes #307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With this PR, chefs should just have to:
qtl analysiswith (at least) options-iand-p; timelines will now be deployed automaticallyqtl analysisreplacesrun-detectors-timelines.shANDdeploy-timelines.shPR
diffSince some scripts were renamed and changed enough such that GitHub does not provide an easy-to-read
diff, here arediffs of the main scripts:run-monitoring.sh -> qtl-histogram
run-detectors-timelines.sh -> qtl-analysis
run-physics-timelines.sh -> qtl-physics
Details
New top-level script
qtlruns everything; it uses subcommands which call other scripts (namedqtl-${subcommand}).The main user-level control scripts have therefore been renamed (to
qtl-*) and redesigned a bit:run-monitoring.shqtl histogram; we preserve symlinkrun-monitoring.shto not breakclas12-workflow; usage remains the samerun-detectors-timelines.shqtl analysis;run-physics-timelines.shqtl physics;deploy-timelines.shqtl analysisandqtl physicsnow handle deployment, see belowerror-print.shqtl errorqtl analysisandqtl physicsnow handle timeline deployment ("publishing") via a new option-p, which specifies the publishing directorydeploy-timelines.shoption-t, which was a "target" directory and required an additional dataset name with option-d, so the full publishing directory would be$target/$datasetIn general, chefs should just have to:
qtl analysiswith (at least) options-iand-pOn the other hand, developers would run:
qtl histogram -d some_dataset_name ...qtl analysis -p $LOGNAME/some_dataset_name(to publish to their personal test web server directory)