add the openshift-provision template processor#147
Conversation
|
I wanted to get the code out there for initial review, I will be brushing up the documentation/example for this, as well as add tests. I was able to manually test the template processor so this code is in a working state |
vinny-sabatini
force-pushed
the
issue-108
branch
2 times, most recently
from
3a21979 to
1420e23
Compare
| - name: Define dynamic hierarchy_paths | ||
| set_fact: | ||
| hierarchy_paths: "{{ hierarchy_paths }} + [ '{{ openshift_cluster_config }}/{{ item.key }}/{{ item.value }}' ]" | ||
| with_dict: "{{ hierarchy }}" |
There was a problem hiding this comment.
It would be great to have tests verifying that the overriding here works as intended
There was a problem hiding this comment.
I will be adding the tests for this and an example for this very soon. I wanted to get the initial code out there so people could start looking in advanced.
vinny-sabatini
force-pushed
the
issue-108
branch
from
1420e23 to
9a9cf62
Compare
|
I have cleaned up some of the changes requested, I will take care of more of them tomorrow when I have more time to test! |
|
@akavel I think I've addressed all of your concerns, please let me know if there's anything else that's unclear/could use improvement |
vinny-sabatini
force-pushed
the
issue-108
branch
from
d221a35 to
27fcbe8
Compare
akavel
left a comment
akavel
left a comment
There was a problem hiding this comment.
I'm not good enough with Kubernetes, so just doing a cursory overview of the example. To that extent, generally looks good to me!
akavel
left a comment
akavel
left a comment
There was a problem hiding this comment.
I understand from our talk on chat that it's actually hard to do tests with openshift, so personally I think I'm ok with this being merged without tests. I guess we could open a separate issue for adding some minishift-based tests? if one's not open yet?
|
@akavel I chatted with @seanmalloy today and he agreed. He will review this when he has time. Thanks for all of your feedback on this PR!! |
vinny-sabatini
force-pushed
the
issue-108
branch
from
59a5744 to
0fa414c
Compare
This template processor utilizes the openshift-provision ansible role Ref: https://github.com/gnuthought/ansible-role-openshift-provision openshift-provision role was pinned to a commit to ensure upstream changes do not break the template processor. Closes #108
vinny-sabatini
force-pushed
the
issue-108
branch
from
0fa414c to
a72a7c8
Compare
3 participants
Description
Introduce a new template processor based on the openshift-provision Ansible role.
Ref: https://github.com/gnuthought/ansible-role-openshift-provision
Remaining items for PR:
- [ ] Add tests for the template processorThis will be done in #186 when #185 is complete.Fixes #108
Type of change