This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Provide a basic variable hierarchy feature#156
Merged
seanmalloy merged 1 commit intomasterfrom Nov 19, 2019
Merged
Conversation
Smiley73
force-pushed
the
basic_hiera
branch
6 times, most recently
from
9130ba7 to
825da6b
Compare
|
@vinny-sabatini what are your thoughts on this, esp. with regards to #147? Do I understand correctly that this could replace part of #147 as a somewhat more general approach? |
akavel
suggested changes
Nov 15, 2019
akavel
left a comment
akavel
left a comment
There was a problem hiding this comment.
The idea seems very cool! The implementation approach seems fine to me too; just numerous minor suggestions... :]
Smiley73
commented
Nov 15, 2019
Contributor
Author
Smiley73
left a comment
Smiley73
left a comment
There was a problem hiding this comment.
@vinny-sabatini what are your thoughts on this, esp. with regards to #147? Do I understand correctly that this could replace part of #147 as a somewhat more general approach?
Yes that's the intention. The openshift-provision is something specific we use at Kohl's, but a lot of user might not want to go down that path.
Smiley73
force-pushed
the
basic_hiera
branch
9 times, most recently
from
d387b2a to
442af14
Compare
akavel
suggested changes
Nov 18, 2019
Smiley73
force-pushed
the
basic_hiera
branch
11 times, most recently
from
d6d1142 to
23f74ad
Compare
Smiley73
force-pushed
the
basic_hiera
branch
13 times, most recently
from
7c1b36e to
f38d4c4
Compare
akavel
reviewed
Nov 19, 2019
akavel
approved these changes
Nov 19, 2019
akavel
pushed a commit
to akavel/eunomia
that referenced
this pull request
Nov 19, 2019
This adds a feature to have a variable hierarchy within the same parameterSource repo. Simply providing a hierarchy.lst file will enable this feature. It's based on the already existing yq merge and simply adds processing of multiple directories. Additional Changes * Updates yq to 2.4.1 * Move configuration files for e2e test into folder test/e2e/configs * Correct ocp e2e test to allow EUNOMIA_REF and EUNOMIA_URI to work * Clean up helm test case and use the hello-world example as the base * Add cluster-admin role to helm example, to support creation of namespace
seanmalloy
force-pushed
the
basic_hiera
branch
from
abb0417 to
2e3d260
Compare
Contributor
|
Looks good. I cleaned up the commit history a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a feature to have a variable hierarchy within the same parameterSource repo. Simply providing a
hiera.lstfile will enable this feature. It's based on the already existingyq mergeand simply adds processing of multiple directories.Additional Changes
test/e2e/configsEUNOMIA_REFandEUNOMIA_URIto workFixes #5
Type of change