present column lineage of a dataset#2293
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2293 +/- ##
=========================================
Coverage 76.72% 76.72%
Complexity 1177 1177
=========================================
Files 222 222
Lines 5354 5354
Branches 429 429
=========================================
Hits 4108 4108
Misses 768 768
Partials 478 478 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabfdff to
365fd5b
Compare
7 tasks
Collaborator
Author
|
Before merging, we need to make sure that backend requests is done after clicking the tab and not by default. |
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
* refactoring for display column lineage JSON Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> * request api after click Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
51fae37 to
d4110e3
Compare
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
d4110e3 to
6c6b329
Compare
phixMe
reviewed
Dec 13, 2022
phixMe
reviewed
Dec 13, 2022
phixMe
reviewed
Dec 15, 2022
phixMe
reviewed
Dec 15, 2022
phixMe
requested changes
Dec 15, 2022
phixMe
left a comment
Member
There was a problem hiding this comment.
Could you look into switching the component that we are fetching from?
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
461fd19 to
0af28e0
Compare
0af28e0 to
a14dfe5
Compare
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
0572063 to
c6d7793
Compare
phixMe
reviewed
Dec 22, 2022
phixMe
approved these changes
Dec 22, 2022
phixMe
left a comment
Member
There was a problem hiding this comment.
Thanks, You'll want to run
npm run eslint-fix to get the project to pass CI, perhaps we need a hook.
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
da84d17 to
cfc329e
Compare
Contributor
Thanks, just pushed changes |
tito12
approved these changes
Dec 27, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* display column lineage JSON Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> * refactoring for display column lineage JSON (#2294) Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> * Refactoring for display column lineage JSON (#2301) * refactoring for display column lineage JSON Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> * request api after click Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> * call backend on tab switch Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> * changes after review. refactoring. fix type and name of file Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Changes after review. Separate fetching data in child component Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * eslint fix changes Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> Co-authored-by: tito12 <vladyslav.sedenko@gmail.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: Pawel Leszczynski <pawelleszczynski@Pawels-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com
Problem
Marquez UI is not presenting column lineage
Solution
This PR provides JSON preview of a column level lineage of a selected dataset.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)