Skip to content

present column lineage of a dataset#2293

Merged
tito12 merged 9 commits into
mainfrom
web/display-column-lineage-of-dataset
Dec 27, 2022
Merged

present column lineage of a dataset#2293
tito12 merged 9 commits into
mainfrom
web/display-column-lineage-of-dataset

Conversation

@pawel-big-lebowski

@pawel-big-lebowski pawel-big-lebowski commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com

Problem

Marquez UI is not presenting column lineage

Solution

This PR provides JSON preview of a column level lineage of a selected dataset.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)
    Zrzut ekranu 2022-12-7 o 12 40 59
    Zrzut ekranu 2022-12-7 o 12 56 14

@boring-cyborg boring-cyborg Bot added the web label Dec 7, 2022
@codecov

codecov Bot commented Dec 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2293 (b52f47c) into main (65669ca) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2293   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pawel-big-lebowski pawel-big-lebowski force-pushed the web/display-column-lineage-of-dataset branch 2 times, most recently from aabfdff to 365fd5b Compare December 7, 2022 11:23
@boring-cyborg boring-cyborg Bot added the docs label Dec 7, 2022
Comment thread web/src/components/datasets/DatasetDetailPage.tsx Outdated
@pawel-big-lebowski pawel-big-lebowski added the javascript Pull requests that update Javascript code label Dec 7, 2022
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review December 7, 2022 11:57
@pawel-big-lebowski pawel-big-lebowski self-assigned this Dec 7, 2022
@pawel-big-lebowski

Copy link
Copy Markdown
Collaborator Author

Before merging, we need to make sure that backend requests is done after clicking the tab and not by default.

@pawel-big-lebowski pawel-big-lebowski marked this pull request as draft December 8, 2022 12:04
pawel-big-lebowski and others added 3 commits December 12, 2022 09:37
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
* refactoring for display column lineage JSON

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

* request api after click

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
@pawel-big-lebowski pawel-big-lebowski force-pushed the web/display-column-lineage-of-dataset branch from 51fae37 to d4110e3 Compare December 12, 2022 08:57
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review December 12, 2022 08:58
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@pawel-big-lebowski pawel-big-lebowski force-pushed the web/display-column-lineage-of-dataset branch from d4110e3 to 6c6b329 Compare December 12, 2022 12:01
Comment thread web/src/components/datasets/DatasetColumnLineage.tsx Outdated
Comment thread web/src/components/datasets/DatasetColumnLineage.tsx Outdated
@howardyoo howardyoo requested a review from phixMe December 15, 2022 15:46
Comment thread web/src/components/datasets/DatasetDetailPage.tsx Outdated
Comment thread web/src/components/datasets/DatasetDetailPage.tsx Outdated

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look into switching the component that we are fetching from?

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12 tito12 force-pushed the web/display-column-lineage-of-dataset branch 2 times, most recently from 461fd19 to 0af28e0 Compare December 21, 2022 13:01
@tito12 tito12 force-pushed the web/display-column-lineage-of-dataset branch from 0af28e0 to a14dfe5 Compare December 21, 2022 13:15
@tito12 tito12 force-pushed the web/display-column-lineage-of-dataset branch from 0572063 to c6d7793 Compare December 21, 2022 15:49
Comment thread web/src/components/datasets/DatasetColumnLineage.tsx

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, You'll want to run
npm run eslint-fix to get the project to pass CI, perhaps we need a hook.

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12 tito12 force-pushed the web/display-column-lineage-of-dataset branch from da84d17 to cfc329e Compare December 23, 2022 19:14
@tito12

tito12 commented Dec 23, 2022

Copy link
Copy Markdown
Contributor

Thanks, You'll want to run npm run eslint-fix to get the project to pass CI, perhaps we need a hook.

Thanks, just pushed changes

@tito12 tito12 merged commit 39bcd3a into main Dec 27, 2022
@tito12 tito12 deleted the web/display-column-lineage-of-dataset branch December 27, 2022 17:02
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* display column lineage JSON

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>

* refactoring for display column lineage JSON (#2294)

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>

* Refactoring for display column lineage JSON  (#2301)

* refactoring for display column lineage JSON

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

* request api after click

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>

* call backend on tab switch

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>

* changes after review. refactoring. fix type and name of file

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>

* Changes after review. Separate fetching data in child component

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>

* eslint fix changes

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Co-authored-by: tito12 <vladyslav.sedenko@gmail.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: Pawel Leszczynski <pawelleszczynski@Pawels-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes chart client/java client/python docker docs javascript Pull requests that update Javascript code web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants