-
Notifications
You must be signed in to change notification settings - Fork 403
present column lineage of a dataset #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e74da10
display column lineage JSON
pawel-big-lebowski 7c08ab3
refactoring for display column lineage JSON (#2294)
tito12 14eb32c
Refactoring for display column lineage JSON (#2301)
tito12 6c6b329
call backend on tab switch
a14dfe5
changes after review. refactoring. fix type and name of file
tito12 f35a23c
Merge branch 'main' into web/display-column-lineage-of-dataset
tito12 c6d7793
Changes after review. Separate fetching data in child component
tito12 cfc329e
eslint fix changes
tito12 b52f47c
Merge branch 'main' into web/display-column-lineage-of-dataset
tito12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { Box } from '@material-ui/core' | ||
| import MqEmpty from '../core/empty/MqEmpty' | ||
| import MqJson from '../core/code/MqJson' | ||
| import React, { FunctionComponent } from 'react' | ||
|
|
||
| interface DatasetColumnLineageProps { | ||
| columnLineage: object | ||
| } | ||
|
|
||
| const DatasetColumnLineage: FunctionComponent<DatasetColumnLineageProps> = props => { | ||
| const { columnLineage } = props | ||
|
|
||
| return ( | ||
| <Box> | ||
| {columnLineage | ||
| ? ( | ||
| <Box mt={2}> | ||
| <MqJson code={columnLineage} /> | ||
| </Box> | ||
|
tito12 marked this conversation as resolved.
Outdated
|
||
| ) | ||
| : ( | ||
| <MqEmpty title={'No column lineage'} body={'Column lineage not available for the specified dataset.'} /> | ||
| ) | ||
| } | ||
| </Box> | ||
| ) | ||
| } | ||
|
|
||
| export default DatasetColumnLineage | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { Dataset } from '../../types/api' | ||
| import { | ||
| FETCH_DATASET, | ||
| FETCH_DATASET_SUCCESS, | ||
| RESET_DATASET | ||
| } from '../actionCreators/actionTypes' | ||
| import { fetchDatasetSuccess } from '../actionCreators'; | ||
|
|
||
| export type IDatasetState = { isLoading: boolean; result: Dataset; init: boolean } | ||
|
|
||
| export const initialState: IDatasetState = { isLoading: false, init: false, result: { } as Dataset } | ||
|
|
||
| type IDatasetAction = ReturnType<typeof fetchDatasetSuccess> | ||
|
|
||
| export default (state: IDatasetState = initialState, action: IDatasetAction): IDatasetState => { | ||
| const { type, payload } = action | ||
|
|
||
| switch (type) { | ||
| case FETCH_DATASET: | ||
| return { ...state, isLoading: true } | ||
| case FETCH_DATASET_SUCCESS: | ||
| return { ...state, isLoading: false, init: true, result: payload.dataset } | ||
| case RESET_DATASET: | ||
| return initialState | ||
| default: | ||
| return state | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.