UI: Selection on graph with edges. Status for jobs/datasets

[tito12]

Problem

According to the issue we are not showing status for jobs and datasets in way we need - based on last quality facets on for datasets and last 14 runs for jobs. This logic should be update, to show this info in correct way.
Also path of selected node and connected to it - is not highligted.
We need to show status of runs and quality facets also in tables with those data, based on the same logic with last 14 records.

Closes: #2169

Solution

This PR provide those changes

Checklist

• You've signed-off your work
• Your changes are accompanied by tests (if relevant)
• Your change contains a small diff and is self-contained
• You've updated any relevant documentation (if relevant)
• You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
• You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
• You've included a header in any source code files (if relevant)

[wslulciuc]

@tito12, did you link the correct issue in your PR description? #2167 is closed and references the soft delete functionality (which has already been added). Anyways, highlighting the lineage path in the graph looks really cool!

[phixMe]

We're bumping versions here for things not related to this workflow. I'm happy to have a PR that only updates these versions, but I think this could potentially cause unrelated issues that are hard to debug.

[tito12]

Updated version for this package to pass tests for new ecmascript features as "optional chaining", because current doesn't support it and throw errors. Do you mean that I can create separate PR for it and it's be okay? Or if I understood wrong, what do you think will be better solution to resolve it? Because it's make code more clean and readable. Thanks

[phixMe]

Let's make this a seperate PR.

[tito12]

Sure, did it, please review #2393

[tito12]

Also reverted changes with versions for this PR.

[tito12]

@tito12, did you link the correct issue in your PR description? #2167 is closed and references the soft delete functionality (which has already been added). Anyways, highlighting the lineage path in the graph looks really cool!

You are right. Added wrong ID by mistake. Already updated to correct

[tito12]

This PR not contain changes for status of jobs on graph, because it's not possible to get all runs with polling each one separately, only for selected job. It's need changes from API side to be able to do that.

[phixMe]

Thanks, 🐑 it!

[wslulciuc]

It's need changes from API side to be able to do that.

@tito12: what API changes would be needed? And would you mind opening an issue to continue the dicussion?

[codecov]

Codecov Report

Merging #2384 (5e3ffcf) into main (9e0c84b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2384   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity     1234     1234           
=========================================
  Files           228      228           
  Lines          5572     5572           
  Branches        447      447           
=========================================
  Hits           4297     4297           
  Misses          775      775           
  Partials        500      500           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[howardyoo]

I've checked the view and it looks great! One comment: the color white to highlight the up and down stream does not seem to stand out too much. Perhaps we could use other colors such as #71ddbf to highlight them, as well as the selected node (job or dataset). Not sure if this little change of color should require a separate PR, but would like to see if @tito12 is willing to perhaps patch it, if possible.

[tito12]

I've checked the view and it looks great! One comment: the color white to highlight the up and down stream does not seem to stand out too much. Perhaps we could use other colors such as #71ddbf to highlight them, as well as the selected node (job or dataset). Not sure if this little change of color should require a separate PR, but would like to see if @tito12 is willing to perhaps patch it, if possible.

Thanks for feedback and sorry for long answer, current PR is closed and merged, but it's not a problem to create another one for it. Do you mean also make this color (kind of green) for selected node with path?

[howardyoo]

I've checked the view and it looks great! One comment: the color white to highlight the up and down stream does not seem to stand out too much. Perhaps we could use other colors such as #71ddbf to highlight them, as well as the selected node (job or dataset). Not sure if this little change of color should require a separate PR, but would like to see if @tito12 is willing to perhaps patch it, if possible.

Thanks for feedback and sorry for long answer, current PR is closed and merged, but it's not a problem to create another one for it. Do you mean also make this color (kind of green) for selected node with path?

Hi @tito12 , yes. I think having the selected node to be colored in 'green' would be great. It doesn't have to be exactly same color as the lines (perhaps the node could be a little darker?) but that would stand out really well.