This fixes the communication of the Web UI component with Marquez AP…#2430
Merged
wslulciuc merged 2 commits intoFeb 28, 2023
Merged
Conversation
…I service in the Helm Chart Signed-off-by: DELRUE Thomas <thomas.delrue@hexagon.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2430 +/- ##
=========================================
Coverage 83.61% 83.61%
Complexity 1214 1214
=========================================
Files 231 231
Lines 5522 5522
Branches 266 266
=========================================
Hits 4617 4617
Misses 762 762
Partials 143 143 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wslulciuc
approved these changes
Feb 28, 2023
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Good catch, @thomas-delrue. Thanks!
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…I service in the Helm Chart (#2430) Signed-off-by: DELRUE Thomas <thomas.delrue@hexagon.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…I service in the Helm Chart
Problem
Deploying the current Helm Chart in main results in a broken Marquez Web Component because of a misconfiguration in the Helm Chart. In the container spec in the Web deployment.yaml file two environment variables are set, i.e. MARQUEZ_HOST and MARQUEZ_PORT, for the instance to be able to communicate with the Marquez API service in the K8s cluster.
The MARQUEZ_PORT is erroneously set to 5000, .Values.marquez.port, the port number used internally in the container for the API, but the Marquez API service is exposed via port number 80, .Values.service.port, within the K8s cluster
Solution
Small fix: define the value for MARQUEZ_PORT as .Values.service.port, i.e. 80. That way Marquez Web component can communicate via http://marquez:80 with the API backend.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)