Gen new uuid for etl_menus ol events#2519
Merged
Merged
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2519 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 1233 1233
=========================================
Files 235 235
Lines 5625 5625
Branches 270 270
=========================================
Hits 4714 4714
Misses 767 767
Partials 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
Signed-off-by: wslulciuc <willy@datakin.com> Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: wslulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OL quickstart produces an invalid lineage graph if Marquez was seeded using the
seedcmd (see related PR OpenLineage/docs#183). That is, in the lineage graph below, the jobmy-jobshould not contain the out edgepublic.menusas an output dataset (linking the two subgraphs):Solution
Believe it or not, the invalid lineage graph is actually, valid! It's the result of a runID collision. That is, the OL events for
my-jobin the quickstart uses the runIDd46e465b-d358-4d32-83d4-df660ff614dd, the same runIDd46e465b-d358-4d32-83d4-df660ff614ddas jobetl_menusinmetadata.json. Therefore, the backend assumes the outputs have changed foretl_menus. This PR generates a new runID4d3b8069-69b6-4708-ade0-3275112c9f04foretl_menusto render the expected lineage graph:Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)