Chart: Dont use hardcoed postgres image for initcontainer#2579
Merged
wslulciuc merged 2 commits intoAug 12, 2023
Conversation
Signed-off-by: daniel.terry <daniel.terry@madepeople.se>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2579 +/- ##
=========================================
Coverage 83.28% 83.28%
Complexity 1287 1287
=========================================
Files 243 243
Lines 5936 5936
Branches 279 279
=========================================
Hits 4944 4944
Misses 845 845
Partials 147 147 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: daniel.terry <daniel.terry@madepeople.se> Co-authored-by: daniel.terry <daniel.terry@madepeople.se> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The marquez deployment has a Postgresql wait-for-db init container with a hardcoded image. Due to this the
global.imageRegistryvalue is not used for the "wait-for-db" init container. This creates problems for users that has to use private registries.Closes: #ISSUE-NUMBER
Solution
I have added a template in
chart/templates/helpers.tplfor the postgres image that returns the value from the postgres chart, or theglobal.imageRegistryinput value . The template is then included in thechart/templates/marquez/deployment.yaml"wait-for-db" initContainer.One-line summary:
Use the same postgresql image value for postgres and "wait-for-db" initcontainer.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)