Skip to content

Chart: Dont use hardcoed postgres image for initcontainer #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wslulciuc merged 2 commits into from
Aug 12, 2023
Merged

Chart: Dont use hardcoed postgres image for initcontainer #2579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85bcac
Dont use hardcoed postgres image for initcontainer
made-terry Aug 11, 2023
c8038a8
Merge branch 'main' into feature/helm/use-postgres-image
wslulciuc Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions chart/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ Return the proper Marquez web image name
{{- include "common.images.image" (dict "imageRoot" .Values.web.image "global" .Values.global) -}}
{{- end -}}

{{/*
Return the proper Postgresql image name for the wait-for-db initContainer
*/}}
{{- define "marquez.wait-for-db.image" -}}
{{- if .Values.postgresql.enabled -}}
{{- include "common.images.image" (dict "imageRoot" .Values.postgresql.image "global" .Values.global) -}}
{{- end -}}
{{- end -}}

{{/*
Get the secret name
*/}}
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/marquez/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
# This init container is for avoiding CrashLoopback errors in the Marquez container because the PostgreSQL container is not ready
initContainers:
- name: wait-for-db
image: postgres:12.1
image: {{ include "marquez.wait-for-db.image" . }}
imagePullPolicy: IfNotPresent
command:
- /bin/bash
Expand Down
⚡