Skip to content

Fixing dataset saga for paging#2615

Merged
wslulciuc merged 3 commits into
mainfrom
fix/dataset-saga
Sep 14, 2023
Merged

Fixing dataset saga for paging#2615
wslulciuc merged 3 commits into
mainfrom
fix/dataset-saga

Conversation

@phixMe

@phixMe phixMe commented Sep 14, 2023

Copy link
Copy Markdown
Member

Problem

Fix for #2614 The paging system didn't work for jobs.

Solution

Updates the saga, changes the default page size.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label Sep 14, 2023
@codecov

codecov Bot commented Sep 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2615 (db60de1) into main (a515c91) will increase coverage by 0.16%.
Report is 55 commits behind head on main.
The diff coverage is 54.54%.

❗ Current head db60de1 differs from pull request most recent head e1ab3d3. Consider uploading reports for the commit e1ab3d3 to get more accurate results

@@             Coverage Diff              @@
##               main    #2615      +/-   ##
============================================
+ Coverage     83.15%   83.31%   +0.16%     
- Complexity     1286     1289       +3     
============================================
  Files           244      243       -1     
  Lines          5942     5940       -2     
  Branches        282      280       -2     
============================================
+ Hits           4941     4949       +8     
+ Misses          854      844      -10     
  Partials        147      147              
Files Changed Coverage Δ
api/src/main/java/marquez/MarquezApp.java 69.04% <0.00%> (+3.13%) ⬆️
api/src/main/java/marquez/db/DbMigration.java 54.28% <ø> (+1.50%) ⬆️
api/src/main/java/marquez/db/JobDao.java 100.00% <ø> (ø)
api/src/main/java/marquez/db/OpenLineageDao.java 96.42% <ø> (ø)
api/src/main/java/marquez/jobs/DbRetentionJob.java 0.00% <0.00%> (ø)
...in/java/marquez/service/RunTransitionListener.java 0.00% <ø> (ø)
...src/main/java/marquez/api/OpenLineageResource.java 90.62% <100.00%> (+0.62%) ⬆️
...a/marquez/db/migrations/V57_1__BackfillFacets.java 87.09% <100.00%> (+1.13%) ⬆️
...java/marquez/service/models/EventTypeResolver.java 96.00% <100.00%> (+4.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phixMe phixMe marked this pull request as ready for review September 14, 2023 18:44
@phixMe phixMe requested a review from wslulciuc September 14, 2023 19:07

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@wslulciuc wslulciuc enabled auto-merge (squash) September 14, 2023 19:43
@wslulciuc wslulciuc merged commit 885e2c6 into main Sep 14, 2023
@wslulciuc wslulciuc deleted the fix/dataset-saga branch September 14, 2023 19:52
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Fixing dataset saga.

Co-authored-by: phix <peter.hicks@astronomer.io>

* Remove log.

Co-authored-by: phix <peter.hicks@astronomer.io>

---------

Co-authored-by: phix <peter.hicks@astronomer.io>
Co-authored-by: Willy Lulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants