Skip to content

Fixing dataset saga for paging #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wslulciuc merged 3 commits into from
Sep 14, 2023
Merged

Fixing dataset saga for paging #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43dc6d2
Fixing dataset saga.
Sep 14, 2023
db60de1
Remove log.
Sep 14, 2023
e1ab3d3
Merge branch 'main' into fix/dataset-saga
wslulciuc Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/store/requests/datasets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { API_URL } from '../../globals'
import { Dataset, DatasetVersions, Datasets } from '../../types/api'
import { genericFetchWrapper } from './index'

export const getDatasets = async (namespace: string, limit = 25, offset = 0) => {
export const getDatasets = async (namespace: string, limit = 20, offset = 0) => {
const url = `${API_URL}/namespaces/${encodeURIComponent(
namespace
)}/datasets?limit=${limit}&offset=${offset}`
Expand Down
7 changes: 6 additions & 1 deletion web/src/store/sagas/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,12 @@ export function* fetchDatasetsSaga() {
while (true) {
try {
const { payload } = yield take(FETCH_DATASETS)
const datasets: Datasets = yield call(getDatasets, payload.namespace)
const datasets: Datasets = yield call(
getDatasets,
payload.namespace,
payload.limit,
payload.offset
)
yield put(fetchDatasetsSuccess(datasets.datasets, datasets.totalCount))
} catch (e) {
yield put(applicationError('Something went wrong while fetching dataset runs'))
Expand Down
⚡