Feat/job to job lineage#2752
Merged
wslulciuc merged 3 commits intoAug 6, 2024
Merged
Conversation
Signed-off-by: yanlibert <yannick.libert@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2752 +/- ##
============================================
- Coverage 84.45% 84.42% -0.04%
- Complexity 1416 1417 +1
============================================
Files 251 251
Lines 6447 6458 +11
Branches 291 291
============================================
+ Hits 5445 5452 +7
- Misses 850 854 +4
Partials 152 152 ☔ View full report in Codecov by Sentry. |
Signed-off-by: yanlibert <yannick.libert@gmail.com>
wslulciuc
approved these changes
Aug 6, 2024
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Can't hide that I'm late getting a review in for this, @yanlibert, but better late than never! Great work! Marquez support for job-to-job relationships has always been on our radar; this just gets us closer to making the lineage query changes to make it happen.
wslulciuc
approved these changes
Aug 6, 2024
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* feat: add parent job UUID to returned metadata Signed-off-by: yanlibert <yannick.libert@gmail.com> * feat: remove unnecessary log Signed-off-by: yanlibert <yannick.libert@gmail.com> --------- Signed-off-by: yanlibert <yannick.libert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, Marquez displays the parent jobs and their child jobs independently with no lineage connection. For exemple, a Airflow task initiated in an Airflow DAG is not visually linked in the UI to its parent, although the information is present in the ParentRunFacet.
Closes: #2484
Solution / Open Questions
This solution mainly serves as the trigger of a larger discussion towards full parent/child hierarchy handling in Marquez. Adding a Job to Job representation in the lineage could be a great step toward a retrieving a more complete picture of the data landscape in general.
For now, the proposed modifications only focuses on the backend API, adding the Job UUID along with the parent name to the job metadata returned.
This could be used by the Front End to display the parent node as a short-term solution.
If we want to go further, this work leads to implementation questions:
One-line summary:
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)