Parent job in job panel#2868
Merged
Merged
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 1470 1470
=========================================
Files 256 256
Lines 6626 6626
Branches 308 308
=========================================
Hits 5617 5617
Misses 856 856
Partials 153 153 ☔ View full report in Codecov by Sentry. |
wslulciuc
reviewed
Aug 7, 2024
wslulciuc
approved these changes
Aug 7, 2024
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Minor comment, but otherwise great to see the quick turn around on getting parent job metadata displayed 💯 💯 💯
alaturqua
pushed a commit
to alaturqua/marquez
that referenced
this pull request
Aug 21, 2024
* Adding parent job from query update. * Formatting and tooltip added. * None --> N/A Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Adding parent job from query update. * Formatting and tooltip added. * None --> N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Due to the update from #2752 we now have the
parentJobNameavailable to us. We now display that in our job panel if it's avaialble. Also added was the job type to even out the metadata that we display.Solution
Simple rendering and type adjustment to accomidate the new field available.
One-line summary:
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)