Use more standard pthread functions#7
Merged
Meziu merged 4 commits intoMeziu:masterfrom Feb 14, 2022
Merged
Conversation
Also adds a get version, to keep consistency.
I chose the scheduler priorities based on https://man7.org/linux/man-pages/man7/sched.7.html I think the cooperative app cores are most like SCHED_FIFO, while the sys core is similar to SCHED_RR. However, I don't think our pthread implementation would be able to accurately return the right policy since we need to know what processor the thread is running on, and the only API to get that gets the ID for the current thread. Since the pthread function passes in a thread ID, we are unable to always get the processor ID and thus the policy. In this case, I think we should just always return (and accept in set) SCHED_FIFO. I don't think this will be used anyways.
5 tasks
ian-h-chamberlain
approved these changes
Feb 13, 2022
AzureMarker
force-pushed
the
tweak/more-standard-thread-functions
branch
from
b4f8459 to
acdce9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some more pthread functions for Meziu/rust-horizon#10