Skip to content

Add "phenotype" to COB#225

Draft
matentzn wants to merge 3 commits intomasterfrom
matentzn-patch-2
Draft

Add "phenotype" to COB#225
matentzn wants to merge 3 commits intomasterfrom
matentzn-patch-2

Conversation

@matentzn
Copy link
Copy Markdown
Contributor

fixes #123

Let the war begin.

fixes #123 

Let the ware begin.
@wdduncan
Copy link
Copy Markdown
Member

Yes ... I imagine there will be a lot of back forth about this.

@matentzn Are you proposing that by making phenotype a top level class that a particular phenotype may be a characteristic, material entity, or process? This suggests to me that it would be better to define a phenotype of object property (which I mentioned here); e.g.:

  • facial tics phenotype of Tourette syndrome
  • tumor phenotype of cancer
  • discoloration phenotype of rash

@addiehl
Copy link
Copy Markdown

addiehl commented Jan 26, 2023

I'm not against the object property approach but I think the inverses should be used here (in a weakened form in some cases):
Tourette syndrome sometimes associated with phenotype facial tics
cancer associated with phenotype tumor (although perhaps cancer disease has basis in tumor might be better although this is a bit chicken and egg)
rash sometimes associated with phenotype discoloration

@matentzn
Copy link
Copy Markdown
Contributor Author

Comment thread src/ontology/cob-edit.owl Outdated

<owl:Class rdf:about="http://purl.obolibrary.org/obo/COB_0001001">
<obo:IAO_0000115>The set of observable characteristics of an individual resulting from the interaction of its genotype with the environment.</obo:IAO_0000115>
<rdfs:label xml:lang="en">phenotype</rdfs:label>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an alternative would be to avoid the shared "phenotype" term, and use phenotypic effect instead, as @dosumis has been suggesting.

@wdduncan
Copy link
Copy Markdown
Member

wdduncan commented Jan 26, 2023

@matentzn In UPHENO, phenotype is a type of quality.

image

Shouldn't it be the same in COB?

@matentzn
Copy link
Copy Markdown
Contributor Author

Yes, this is really controversial, and should probably not be in Upheno..

@matentzn matentzn marked this pull request as draft February 19, 2023 15:20
@wdduncan
Copy link
Copy Markdown
Member

wdduncan commented Mar 8, 2026

There hasn't been any discussion on this in quite a while.
Since the proposed definition for phenotype (or perhaps phenotypic effect) is:

The set of observable characteristics of an individual resulting from the interaction of its genotype with the environment.

Would it be better to define a term for "environment-genotype interaction" (if one doesn't exist) and the define a phenotypes as "output of" that process? This would still encompass a large number of different types of things, but perhaps make the term "phenotype" more palatable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Where to place phenotype?

3 participants