Skip to content

[12.0][IMP] l10n_it_ricevute_bancarie, manage multiple bank in partner#2064

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
GSLabIt:12.0-ricevute_bancarie-allow_bank_selection
Jan 27, 2021
Merged

[12.0][IMP] l10n_it_ricevute_bancarie, manage multiple bank in partner#2064
OCA-git-bot merged 1 commit into
OCA:12.0from
GSLabIt:12.0-ricevute_bancarie-allow_bank_selection

Conversation

@GSLabIt

@GSLabIt GSLabIt commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

Descrizione del problema o della funzionalità:

Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

elvise
elvise approved these changes Jan 21, 2021
View reviewed changes

@elvise elvise left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lato funzionale ok!

@GSLabIt

GSLabIt commented Jan 22, 2021

Copy link
Copy Markdown
Contributor Author

@sergiocorato @eLBati travis è rosso su righe non modificate, vi è possibile fare review e merge?

scigghia
scigghia approved these changes Jan 23, 2021
View reviewed changes

@scigghia scigghia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho fatto un test funzionale e mi sembra una buona soluzione, codice ok
👍

primes2h
primes2h requested changes Jan 23, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/models/account/account.py Outdated
@sergiocorato

sergiocorato commented Jan 24, 2021

Copy link
Copy Markdown
Contributor

@sergiocorato @eLBati travis è rosso su righe non modificate, vi è possibile fare review e merge?

C'è un banale errore di pylint, poi però le modifiche rompono i test sulle riba, quindi va verificato il motivo e risolto.

@GSLabIt

GSLabIt commented Jan 25, 2021

Copy link
Copy Markdown
Contributor Author

@sergiocorato @eLBati travis è rosso su righe non modificate, vi è possibile fare review e merge?

C'è un banale errore di pylint, poi però le modifiche rompono i test sulle riba, quindi va verificato il motivo e risolto.

test fixed

tafaRU
tafaRU requested changes Jan 26, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/models/account/account.py Outdated
GSLabIt
GSLabIt commented Jan 26, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/tests/test_riba.py Outdated
@GSLabIt GSLabIt force-pushed the 12.0-ricevute_bancarie-allow_bank_selection branch from 2059c28 to 7843dcb Compare January 26, 2021 19:15
tafaRU
tafaRU requested changes Jan 27, 2021
View reviewed changes

@tafaRU tafaRU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al termine delle modifiche richieste ti chiederei di squashare tutti i commit in uno solo.
Grazie!

Comment thread l10n_it_ricevute_bancarie/models/account/account.py Outdated
@GSLabIt GSLabIt force-pushed the 12.0-ricevute_bancarie-allow_bank_selection branch from 7843dcb to b11462b Compare January 27, 2021 10:47
tafaRU
tafaRU approved these changes Jan 27, 2021
View reviewed changes

@tafaRU tafaRU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie! 👍

@GSLabIt

GSLabIt commented Jan 27, 2021

Copy link
Copy Markdown
Contributor Author

Grazie! 👍

Possibile fare il merge?

@tafaRU

tafaRU commented Jan 27, 2021

Copy link
Copy Markdown
Member

Possibile fare il merge?

attendiamo prima che @primes2h aggiorni la sua review.

@GSLabIt

GSLabIt commented Jan 27, 2021

Copy link
Copy Markdown
Contributor Author

Possibile fare il merge?

attendiamo prima che @primes2h aggiorni la sua review.

In realtà ho "mergiato" i suoi suggerimenti

@tafaRU

tafaRU commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Ok @GSLabIt dobbiamo però comunque prima attendere che aggiorni la sua review 😉
image

primes2h
primes2h approved these changes Jan 27, 2021
View reviewed changes

@primes2h primes2h left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU

tafaRU commented Jan 27, 2021

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-2064-by-tafaRU-bump-minor, awaiting test results.

@primes2h

primes2h commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-2064-by-primes2h-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 27, 2021
@OCA-git-bot
Merge PR #2064 into 12.0
12ddd28 
Signed-off-by primes2h
@primes2h

primes2h commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

Ops... scusa @tafaRU non avevo visto che avevi già lanciato ocabot. 😅

@OCA-git-bot OCA-git-bot merged commit d0417f1 into OCA:12.0 Jan 27, 2021
@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 2032e4a. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2064-by-primes2h-bump-minor, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ef5fef9. Thanks a lot for contributing to OCA. ❤️

@GSLabIt

GSLabIt commented Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

@tafaRU è il caso di creare uno script di migrazione per aggiungere il conto sulle fatture già emesse con termini di pagamento riba?

eLBati
eLBati reviewed Jan 29, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/wizard/wizard_riba_issue.py
bank_id = move_line.invoice_id.riba_partner_bank_id
else:
raise exceptions.Warning(
_('No bank has been specified for partner %s!') %

@eLBati eLBati Jan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarebbe bene anche adeguare il messaggio: "No bank has been specified for invoice %s"

@eLBati

eLBati commented Jan 29, 2021

Copy link
Copy Markdown
Member

è il caso di creare uno script di migrazione per aggiungere il conto sulle fatture già emesse con termini di pagamento riba?

@GSLabIt sicuramente male non farebbe.
Sarebbe giusto per coprire quelle fatture senza riba_partner_bank_id per le quali deve ancora essere emessa la distinta (che ora si beccherebbero un messaggio poco chiaro : #2064 (comment) )

@GSLabIt

GSLabIt commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

@eLBati che versione per il migration script? 12.0.1.6.0 oppure la prox, presumibilmente 12.0.1.6.1?

@eLBati

eLBati commented Jan 29, 2021

Copy link
Copy Markdown
Member

@GSLabIt modifichi la versione nel manifest e metti la stessa in migrations

@GSLabIt

GSLabIt commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

@eLBati altra info veloce, post-migrate.py o post-migration.py?

@eLBati

eLBati commented Feb 1, 2021

Copy link
Copy Markdown
Member

Io uso sempre post-migration.py, però forse van bene entrambi

@tafaRU

tafaRU commented Feb 2, 2021

Copy link
Copy Markdown
Member

però forse van bene entrambi

Affinché gli script di migrazione vengano eseguiti devono iniziare per pre- o per post- (rif. link ).

@Borruso Borruso mentioned this pull request Sep 17, 2021
Merged
@HekkiMelody HekkiMelody mentioned this pull request Jul 6, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eLBati eLBati eLBati left review comments

@primes2h primes2h primes2h approved these changes

@tafaRU tafaRU tafaRU approved these changes

+2 more reviewers

@elvise elvise elvise approved these changes

@scigghia scigghia scigghia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@GSLabIt @sergiocorato @tafaRU @OCA-git-bot @primes2h @eLBati @elvise @scigghia
⚡