Skip to content

[12.0][IMP] post-migrate script to set bank on invoice#2081

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
GSLabIt:12.0-imp-l10n_it_ricevute_bancarie-migration_script
Feb 3, 2021
Merged

[12.0][IMP] post-migrate script to set bank on invoice#2081
OCA-git-bot merged 1 commit into
OCA:12.0from
GSLabIt:12.0-imp-l10n_it_ricevute_bancarie-migration_script

Conversation

@GSLabIt

@GSLabIt GSLabIt commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

Descrizione del problema o della funzionalità:

Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@GSLabIt GSLabIt force-pushed the 12.0-imp-l10n_it_ricevute_bancarie-migration_script branch from c3f15a8 to f43985f Compare January 29, 2021 18:13
@GSLabIt

GSLabIt commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

@tafaRU @eLBati come avete un momento, review?

tafaRU
tafaRU requested changes Feb 1, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/migrations/12.0.1.6.1/post-migrate.py Outdated
Comment thread l10n_it_ricevute_bancarie/migrations/12.0.1.6.1/post-migrate.py Outdated
Comment thread l10n_it_ricevute_bancarie/migrations/12.0.1.6.1/post-migrate.py Outdated
Comment thread l10n_it_ricevute_bancarie/migrations/12.0.1.6.1/post-migrate.py Outdated
@GSLabIt GSLabIt force-pushed the 12.0-imp-l10n_it_ricevute_bancarie-migration_script branch from f43985f to 83b7609 Compare February 1, 2021 10:17
@GSLabIt

GSLabIt commented Feb 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tafaRU una domanda, con queste modifiche è necessario installare openupgradelib per poter eseguire la migrazione correttamente?

@tafaRU

tafaRU commented Feb 1, 2021

Copy link
Copy Markdown
Member

con queste modifiche è necessario installare openupgradelib per poter eseguire la migrazione correttamente?

yes, @GSLabIt. Usando la versione prelevata dal branch master, ovvero con:

pip install git+https://github.com/OCA/openupgradelib.git@master

@GSLabIt

GSLabIt commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

con queste modifiche è necessario installare openupgradelib per poter eseguire la migrazione correttamente?

yes, @GSLabIt. Usando la versione prelevata dal branch master, ovvero con:

pip install git+https://github.com/OCA/openupgradelib.git@master

in questo modo, non "obblighiamo" ad installare le lib per evitare errori? Dovremmo segnalarlo?

@tafaRU

tafaRU commented Feb 1, 2021

Copy link
Copy Markdown
Member

in questo modo, non "obblighiamo" ad installare le lib per evitare errori?

la maggior parte dei moduli OCA usano questa versione di openupgradelib.

Dovremmo segnalarlo?

male di certo non fa!

@GSLabIt

GSLabIt commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

in questo modo, non "obblighiamo" ad installare le lib per evitare errori?

la maggior parte dei moduli OCA usano questa versione di openupgradelib.

Dovremmo segnalarlo?

male di certo non fa!

Meglio sarebbe segnalarlo per l'intera repo,

@tafaRU

tafaRU commented Feb 1, 2021

Copy link
Copy Markdown
Member

Meglio sarebbe segnalarlo per l'intera repo,

ok, fai pure PR. Grazie.

@sergiocorato

sergiocorato commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2081-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2021
@OCA-git-bot
Merge PR #2081 into 12.0
ea3f7ac 
Signed-off-by sergiocorato
@OCA-git-bot

OCA-git-bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2081-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2021
@OCA-git-bot
Merge PR #2081 into 12.0
94b4dfc 
Signed-off-by sergiocorato
@OCA-git-bot

OCA-git-bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2081-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2021
@OCA-git-bot
Merge PR #2081 into 12.0
7386c3a 
Signed-off-by sergiocorato
@OCA-git-bot

OCA-git-bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

@sergiocorato your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-2081-by-sergiocorato-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sergiocorato

sergiocorato commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2081-by-sergiocorato-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4b2d4cf into OCA:12.0 Feb 3, 2021
@OCA-git-bot

OCA-git-bot commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d74d4e4. Thanks a lot for contributing to OCA. ❤️

eLBati
eLBati reviewed Feb 3, 2021
View reviewed changes
Comment thread l10n_it_ricevute_bancarie/migrations/12.0.1.6.1/post-migrate.py
('payment_term_id.riba', '=', True), ('riba_partner_bank_id', '=', False)
])
for invoice in invoices:
invoice._onchange_riba_partner_bank_id()

@eLBati eLBati Feb 3, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questo onchange scrive nel DB senza bisogno di _convert_to_write?

@GSLabIt GSLabIt Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nei test ha funzionato senza, meglio aggiungerlo?

@eLBati eLBati Feb 3, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se funziona va bene, ma mi chiedevo come fa

@GSLabIt GSLabIt Feb 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In realtà me lo sono chiesto anche io 😬 possibile per l'utilizzo di delle librerie openupgradelib?

@eLBati eLBati Feb 5, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ecco: https://discord.com/channels/753902328494424064/753902328494424070/807184531554828329

@Borruso Borruso mentioned this pull request Sep 17, 2021
Merged
@GSLabIt GSLabIt mentioned this pull request Mar 18, 2022
Closed
2 tasks
@HekkiMelody HekkiMelody mentioned this pull request Jul 6, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eLBati eLBati eLBati left review comments

@tafaRU tafaRU tafaRU approved these changes

@sergiocorato sergiocorato sergiocorato approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GSLabIt @tafaRU @sergiocorato @OCA-git-bot @eLBati
⚡