Skip to content

[MIG] l10n_it_delivery_note_base: Migration to 14.0#2140

Merged
OCA-git-bot merged 6 commits into
OCA:14.0from
fredzamoabg:14.0-mig-delivery_note_base
Mar 19, 2021
Merged

[MIG] l10n_it_delivery_note_base: Migration to 14.0#2140
OCA-git-bot merged 6 commits into
OCA:14.0from
fredzamoabg:14.0-mig-delivery_note_base

Conversation

@fredzamoabg

Copy link
Copy Markdown
Contributor

migrazione l10n_it_delivery_note_base

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@fredzamoabg fredzamoabg force-pushed the 14.0-mig-delivery_note_base branch from 3fa80b1 to ae8b14c Compare February 26, 2021 14:31
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Feb 26, 2021
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-delivery_note_base branch from ae8b14c to 825090c Compare March 4, 2021 08:07
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-delivery_note_base branch from 825090c to e50bf06 Compare March 4, 2021 15:34
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MarcoCalcagni MarcoCalcagni left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@TheMule71

Copy link
Copy Markdown
Contributor

Potresti per cortesia splittare il commit in due come da guida per la migrazione... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

@fredzamoabg

Copy link
Copy Markdown
Contributor Author

Potresti per cortesia splittare il commit in due come da guida per la migrazione... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

non capisco a che split di commit ti riferisci

@TheMule71

TheMule71 commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Potresti per cortesia splittare il commit in due come da guida per la migrazione... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

non capisco a che split di commit ti riferisci

La procedura iniziale è questa:

$ git clone https://github.com/OCA/$REPO -b 14.0
$ git checkout -b 14.0-mig-$MODULE origin/14.0
$ git format-patch --keep-subject --stdout origin/14.0..origin/13.0 -- $MODULE | git am -3 --keep
$ pre-commit run -a # to run black, isort and prettier (ignore pylint errors at this stage)
$ git add -A
$ git commit -m "[IMP] $MODULE: black, isort, prettier" --no-verify # it is important to do all formatting in one commit the first time

mi riferisco alle ultime righe. Ci deve essere un commit che contiene le modifiche fatte (e solo quelle) dai tool di pre-commit.

Se non erro questo commit e50bf06 contiene sia modifiche di formattazione sia modifiche funzionali.

@fredzamoabg

Copy link
Copy Markdown
Contributor Author

Potresti per cortesia splittare il commit in due come da guida per la migrazione... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

non capisco a che split di commit ti riferisci

La procedura iniziale è questa:

$ git clone https://github.com/OCA/$REPO -b 14.0
$ git checkout -b 14.0-mig-$MODULE origin/14.0
$ git format-patch --keep-subject --stdout origin/14.0..origin/13.0 -- $MODULE | git am -3 --keep
$ pre-commit run -a # to run black, isort and prettier (ignore pylint errors at this stage)
$ git add -A
$ git commit -m "[IMP] $MODULE: black, isort, prettier" --no-verify # it is important to do all formatting in one commit the first time

mi riferisco alle ultime righe. Ci deve essere un commit che contiene le modifiche fatte (e solo quelle) dai tool di pre-commit.

Se non erro questo commit e50bf06 contiene sia modifiche di formattazione sia modifiche funzionali.

Devo dire che questa richiesta a questo punto della PR mi sembra un po eccessiva e perditempo. Capisco che faccia parte della procedura, e mi scuso se non l'ho seguita alla lettera, ma se non è strettamente necessario (e non lo è sicuramente dal punto di vista funzionale) questa modifica la eviterei.

@TheMule71

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2140-by-TheMule71-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eab4fbc into OCA:14.0 Mar 19, 2021
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9e65ac7. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Mar 19, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants