Skip to content

[14.0][MIG] l10n_it_withholding_tax_payment#2238

Merged
OCA-git-bot merged 27 commits into
OCA:14.0from
SimoRubi:14.0-mig-l10n_it_withholding_tax_payment
Oct 15, 2021
Merged

[14.0][MIG] l10n_it_withholding_tax_payment#2238
OCA-git-bot merged 27 commits into
OCA:14.0from
SimoRubi:14.0-mig-l10n_it_withholding_tax_payment

Conversation

@tafaRU tafaRU mentioned this pull request May 20, 2021
76 tasks
@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_withholding_tax_payment branch from 3501f57 to 0e729d6 Compare June 4, 2021 07:17
@SimoRubi SimoRubi marked this pull request as ready for review July 2, 2021 07:30
@SimoRubi

Copy link
Copy Markdown
Member Author

@andreampiovesana @francescapenso voi l'avete provato? Potete lasciare una review funzionale?

@francescapenso

Copy link
Copy Markdown

l'ho provata al volo. Suggerirei prima di tutto di riscrivere il file rdm perchè non è chiaro a cosa serve il modulo.

ho trovato una descrizione in 8.0 ma va verificato se è corretta o perchè sia andata persa. Magari anche utile una "guida funzionale"

Provandola al volo in una mia installazione non riesco a salvare per un errore "multicompany", l'utente che sto usando è admin di tutto

image

alessandrocamilli and others added 8 commits August 13, 2021 12:42
[FIX] 10.0 api compat

First beta

Travis check

Ref name

[FIX] Compute WT only if the invoice has wt lines

Added feature to unreconcile the wt move created by payment, and after it possible to re-reconcile
[FIX] add display_name on class  withholding.tax.move withholding.tax.statement

[FIX] add display_name on class  withholding.tax.move withholding.tax.statement

[FIX] removed select on class l10n_it_withholding_tax l10n_it_withholding_tax_payment

[FIX] add README
Disabled delete from tree view of wt statements and wt moves

Rates required

Disabled delete from tree view of wt statements and wt moves

Fix conflicts and changed code with new standards
FIX l10n_it_withholding_tax (OCA#416)

Gli oggetti withholding.tax.move, withholding.tax.statement e withholding.tax.move.payment si possono eliminare dalla vista elendo dei relativi menu
check wt_moves

Added rules

Show payment move after generation from wt moves

More check for payment unreconciliation

Company readonly in payment wt

Company readonly in payment wt

Fix conflict with translation
* [FIX] Travis check and readonly on company_id

* [FIX] Travis check and readonly on company_id
odoo/tools/translate.py", line 539, in next
    raise Exception("malformed file: bad line: %s" % line)
Exception: malformed file: bad line: # * l10n_it_withholding_tax

Restore l10n_it_withholding_tax_payment/i18n/lt.po
@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_withholding_tax_payment branch from e2c4a5a to 6a50d10 Compare August 27, 2021 13:51

@stevech091 stevech091 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approvata

@SimoRubi

Copy link
Copy Markdown
Member Author

@francescapenso ho migliorato il README, ora va meglio? Ogni suggerimento è ben accetto

@tafaRU

tafaRU commented Oct 15, 2021

Copy link
Copy Markdown
Member

@francescapenso il problema che segnalavi in #2238 (comment) è stato risolto con 02e7a94 Visto e considerato che è trascorso molto tempo dalla richiesta di verifica (#2238 (comment)) procediamo con il Merge. Grazie della segnalazione.

@tafaRU

tafaRU commented Oct 15, 2021

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2238-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1b5afb7 into OCA:14.0 Oct 15, 2021
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ee4a4ab. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.