[14.0] IMP l10n_it_fatturapa_out: forward port of #2300#2309
Conversation
TheMule71
force-pushed
the
14.0-forward-2300
branch
2 times, most recently
from
57a7cf2 to
ed3f701
Compare
SimoRubi
left a comment
SimoRubi
left a comment
There was a problem hiding this comment.
Grazie della PR!
Riesci ad aggiungere un test?
| def preventive_checks(self): | ||
| for invoice in self: | ||
| if not invoice.is_sale_document(): | ||
| raise UserError(_("Impossible to generate XML: not a customer invoice")) |
There was a problem hiding this comment.
Puoi segnalare all'utente qual'è il documento incriminato?
There was a problem hiding this comment.
Bisognerebbe proporre la stessa cosa per #2300, ma è stata già mergiata così com'è.
There was a problem hiding this comment.
Fatto (il nome della fattura)
TheMule71
force-pushed
the
14.0-forward-2300
branch
from
ed3f701 to
f270115
Compare
Fatto. |
|
testata con fattura fornitore e tentato export e mi ha bloccato correttamente |
| _( | ||
| "Impossible to generate XML: not a customer invoice: %s" | ||
| % invoice.name | ||
| ) |
There was a problem hiding this comment.
| _( | |
| "Impossible to generate XML: not a customer invoice: %s" | |
| % invoice.name | |
| ) | |
| _("Impossible to generate XML: not a customer invoice: %s") | |
| % invoice.name |
La sostituzione andrebbe fatta dopo la traduzione e non viceversa, altrimenti Odoo cercherà la traduzione della stringa con già il numero di fattura inserito tipo
Impossible to generate XML: not a customer invoice: ACQ/2021/09/0001
senza trovarla e l'errore presenterà la stringa non tradotta. Puoi correggere?
TheMule71
force-pushed
the
14.0-forward-2300
branch
from
f270115 to
ef7142c
Compare
IMP l10n_it_fatturapa_out: prevent to export XML for vendor bills. This is possible by "sidebar" actions Co-authored-by: Lorenzo Battistini <lb@takobi.online>
TheMule71
force-pushed
the
14.0-forward-2300
branch
from
ef7142c to
4540c30
Compare
SimoRubi
left a comment
SimoRubi
left a comment
There was a problem hiding this comment.
Revisione del codice, per me è ok
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at dd1a8db. Thanks a lot for contributing to OCA. ❤️ |
5 participants
IMP l10n_it_fatturapa_out: prevent to export XML for vendor bills.
This is possible by "sidebar" actions
#2301
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing