Skip to content

[16.0] [MIG] l10n_it_website_portal_fiscalcode#3025

Closed
AlessandroSkab wants to merge 20 commits into
OCA:16.0from
AlessandroSkab:16.0-mig-l10n_it_website_portal_fiscalcode
Closed

[16.0] [MIG] l10n_it_website_portal_fiscalcode#3025
AlessandroSkab wants to merge 20 commits into
OCA:16.0from
AlessandroSkab:16.0-mig-l10n_it_website_portal_fiscalcode

Conversation

@AlessandroSkab

Copy link
Copy Markdown

Migrazione da versione 14.0 a 16.0

@AlessandroSkab AlessandroSkab changed the title 16.0 mig l10n it website portal fiscalcode [16.0] [MIG] l10n_it_website_portal_fiscalcode Nov 11, 2022
@eLBati

eLBati commented Nov 11, 2022

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_website_portal_fiscalcode

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 11, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 11, 2022
81 tasks

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In setup/l10n_it_website_portal_fiscalcode/odoo/addons/ dovrebbe esserci un link simbolico.

In locale, se rimuovo setup/l10n_it_website_portal_fiscalcode/ e lancio pre-commit run -a mi crea il link simbolico correttamente

monen17 and others added 20 commits November 15, 2022 11:07
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/
Steps:

 - Create a partner (type company) and give them portal access
 - With the new user, access to portal
 - Edit partner details setting fiscal code with 11 digits
 - Using admin, create an invoice for that partner and validate
 - Using the new user, access to portal, open partner details and save

Get "The fiscal code doesn't seem to be correct"
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/
Currently translated at 100.0% (2 of 2 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/it/
@AlessandroSkab

Copy link
Copy Markdown
Author

In setup/l10n_it_website_portal_fiscalcode/odoo/addons/ dovrebbe esserci un link simbolico.

In locale, se rimuovo setup/l10n_it_website_portal_fiscalcode/ e lancio pre-commit run -a mi crea il link simbolico correttamente

Il terminale su W11 non generava link simbolici senza i permessi di Administrator.
Abbiamo risolto eseguendolo come tale.

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provato il modulo, sembra funzionare correttamente.

Code review, un paio di dettagli da aggiustare

>
<xpath
expr="//div[hasclass('o_portal_details')]/div[1]/div[1]/div[7]"
expr="//t[@t-name='portal.portal_my_details_fields']/div[8]"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualcosa del genere potrebbe essere più robusto?

<xpath expr="//div[label[@for='vat']]">

>
<label
class="col-form-label label-optional"
for="vat"

@HekkiMelody HekkiMelody May 22, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for="fiscalcode"

Comment on lines +13 to +16
def details_form_validate(self, data):
error, error_message = super(
WebsitePortalFiscalCode, self
).details_form_validate(data)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la firma di details_form_validate è cambiata:

Suggested change
def details_form_validate(self, data):
error, error_message = super(
WebsitePortalFiscalCode, self
).details_form_validate(data)
def details_form_validate(self, data, partner_creation=False):
error, error_message = super(
WebsitePortalFiscalCode, self
).details_form_validate(data, partner_creation)

@tafaRU

tafaRU commented May 30, 2023

Copy link
Copy Markdown
Member

Chiudo in favore di #3338

@tafaRU tafaRU closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.