[16.0] [MIG] l10n_it_website_portal_fiscal_code by HekkiMelody · Pull Request #3338 · OCA/l10n-italy

HekkiMelody · 2023-05-30T07:59:41Z

Superseeds #3025

tafaRU · 2023-07-06T08:27:40Z

/ocabot rebase

OCA-git-bot · 2023-07-06T08:27:45Z

@tafaRU The rebase process failed, because command git push --force PyTech-SRL tmp-pr-3338:16.0-mig-l10n-it-portal-fiscal-code failed with output:

remote: Permission to PyTech-SRL/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/PyTech-SRL/l10n-italy/': The requested URL returned error: 403

HekkiMelody · 2023-07-06T08:43:29Z

Fatto il rebase a mano

SirAionTech

Grazie della PR!
Potresti modificare la storia dei commit come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests?

SirAionTech · 2023-09-07T09:43:59Z

        error, error_message = super(
            WebsitePortalFiscalCode, self
-        ).details_form_validate(data)
+        ).details_form_validate(data, partner_creation)


È possibile passare l'argomento con partner_creation=partner_creation?
Altrimenti, se qualche altro modulo dovesse modificare l'ordine dei kwarg non verrebbero assegnati i parametri corretti.

SirAionTech · 2023-09-07T09:52:36Z

+                    for="fiscalcode"
                >Fiscal Code</label>
                <input
                    type="text"


Più sotto negli attributi t-att* si usano logiche copiate da come era fatto il template in 14.0, queste sono però state corrette in 16.0 (vedi odoo/odoo@beb50e8); è possibile riportare le correzioni anche in questa migrazione?

guidgaro

Ho testato il modulo e funziona correttamente.

eLBati · 2023-09-25T13:55:57Z

/ocabot rebase

OCA-git-bot · 2023-09-25T13:56:05Z

@eLBati The rebase process failed, because command git push --force PyTech-SRL tmp-pr-3338:16.0-mig-l10n-it-portal-fiscal-code failed with output:

remote: Permission to PyTech-SRL/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/PyTech-SRL/l10n-italy/': The requested URL returned error: 403

francesco-ooops · 2023-09-25T13:57:58Z

@renda-dev o @PicchiSeba riuscite voi?

PicchiSeba · 2023-09-25T14:32:53Z

@francesco-ooops proviamo adesso

TheMule71 · 2023-09-25T20:46:37Z

/ocabot rebase

OCA-git-bot · 2023-09-25T20:47:51Z

@TheMule71 The rebase process failed, because command git push --force PyTech-SRL tmp-pr-3338:16.0-mig-l10n-it-portal-fiscal-code failed with output:

remote: Permission to PyTech-SRL/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/PyTech-SRL/l10n-italy/': The requested URL returned error: 403

PicchiSeba · 2023-09-26T06:51:52Z

Devo sentire l'amministratore del nostro fork. Vi taggo non appena sblocchiamo la situazione

FrancescoBallerini

Functional : LGTM

Borruso · 2023-10-05T08:30:55Z

            >
                <label
                    class="col-form-label label-optional"
-                    for="vat"


riga 29

t-att-disabled="None if partner_can_edit_vat else '1'"

riga 30

t-att-title="None if partner_can_edit_vat else 'Changing Fiscal Code is not allowed once document(s) have been issued for your account. Please contact us directly for this operation.'"

https://github.com/odoo/odoo/blob/16.0/addons/website_sale/views/templates.xml#L1843

Per consistenza con gli altri campi, sarei per mantenere readonly invece che disabled

ti chiedevo di modificarla perché coerente con la vista
https://github.com/odoo/odoo/blob/16.0/addons/portal/views/portal_templates.xml#L404
che stai facendo modificando

è solo un osservazione per me va bene anche così

done!

puoi controllare vedo ancora if partner.partner.can_edit_vat() else invece che if partner_can_edit_vat else

Lo sapevate che se non salvi il file, poi sul file non vengono scritte le modifiche? Sapevatelo.

andreampiovesana

LGTM - functional review

marcelofrare

LGTM

MaurizioPellegrinet

LGTM

HekkiMelody · 2023-10-06T07:59:58Z

Metto in draft per non avere merge preventivi, visto che ho ricevuto un sacco di approvazioni, ma vorrei guardare quello che hanno suggerito @Borruso e @SirAionTech . Spero di avere tempo oggi.

Steps: - Create a partner (type company) and give them portal access - With the new user, access to portal - Edit partner details setting fiscal code with 11 digits - Using admin, create an invoice for that partner and validate - Using the new user, access to portal, open partner details and save Get "The fiscal code doesn't seem to be correct"

Currently translated at 100.0% (2 of 2 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/it/

HekkiMelody · 2023-10-06T10:07:02Z

Done

SirAionTech

Vedo che hai incluso 9a879d9 nel commit di migrazione, sarebbe stato da mantenere nella history come gli altri commit di 14.0, riesci a correggere?
Altrimenti ci sarebbe almeno da chiedere all'autore @FrancescoBallerini se va bene così

SirAionTech · 2023-10-06T10:13:16Z

+    def details_form_validate(self, data, partner_creation=False):
+        error, error_message = super(
+            WebsitePortalFiscalCode, self
+        ).details_form_validate(data, partner_creattion=partner_creation)


Suggested change

).details_form_validate(data, partner_creattion=partner_creation)

).details_form_validate(data, partner_creation=partner_creation)

È preoccupante che i test passassero anche con questo typo

FrancescoBallerini · 2023-10-06T10:37:01Z

Vedo che hai incluso 9a879d9 nel commit di migrazione, sarebbe stato da mantenere nella history come gli altri commit di 14.0, riesci a correggere? Altrimenti ci sarebbe almeno da chiedere all'autore @FrancescoBallerini se va bene così

Non sono certo di come funzioni il mantenimento della commit history per le migrazioni, tuttavia sono abbastanza sicuro che non servirà un "rollback" del commit vista l'entità della modifica, al di la di questo non so se possa creare altre problematiche.. ma per me non è un gran problema se decidete di includerla direttamente perdendo eventualmente il commit

HekkiMelody · 2023-10-06T10:39:11Z

Vedo che hai incluso 9a879d9 nel commit di migrazione, sarebbe stato da mantenere nella history come gli altri commit di 14.0, riesci a correggere? Altrimenti ci sarebbe almeno da chiedere all'autore @FrancescoBallerini se va bene così

Non credo di averlo incluso, era una correzione che avevo rifatto io, non sapevo ci fosse la PR per la 14. Io sono partito prendendo #3025 così com'era. Comunque adesso per pulizia faccio cherry-pick

FrancescoBallerini · 2023-10-06T11:16:00Z

Vedo che hai incluso 9a879d9 nel commit di migrazione, sarebbe stato da mantenere nella history come gli altri commit di 14.0, riesci a correggere? Altrimenti ci sarebbe almeno da chiedere all'autore @FrancescoBallerini se va bene così

Non credo di averlo incluso, era una correzione che avevo rifatto io, non sapevo ci fosse la PR per la 14. Io sono partito prendendo #3025 così com'era. Comunque adesso per pulizia faccio cherry-pick

In tal caso, se dovesse tornarti utile questa è la PR con il commit #3521

OpenCode · 2023-10-06T11:18:51Z

/ocabot merge nobump

OCA-git-bot · 2023-10-06T11:18:56Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3338-by-OpenCode-bump-nobump, awaiting test results.

Signed-off-by OpenCode

OCA-git-bot · 2023-10-06T11:47:51Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3338-by-OpenCode-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-06T12:11:16Z

Congratulations, your PR was merged at 3763994. Thanks a lot for contributing to OCA. ❤️

This was referenced May 30, 2023

[16.0] [MIG] l10n_it_website_portal_fiscalcode #3025

Closed

Migration to version 16.0 #2967

Open

DinamicheAziendali mentioned this pull request Jun 29, 2023

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

tafaRU added the needs functional review label Jul 6, 2023

HekkiMelody force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from ca57bde to c2df466 Compare July 6, 2023 08:43

SirAionTech suggested changes Sep 7, 2023

View reviewed changes

guidgaro approved these changes Sep 7, 2023

View reviewed changes

PicchiSeba force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from c2df466 to 1f60375 Compare September 25, 2023 14:30

FrancescoBallerini approved these changes Sep 29, 2023

View reviewed changes

Borruso suggested changes Oct 5, 2023

View reviewed changes

HekkiMelody force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from 1f60375 to bb7fd1b Compare October 5, 2023 12:17

andreampiovesana approved these changes Oct 5, 2023

View reviewed changes

marcelofrare approved these changes Oct 5, 2023

View reviewed changes

MaurizioPellegrinet approved these changes Oct 5, 2023

View reviewed changes

HekkiMelody marked this pull request as draft October 6, 2023 07:59

HekkiMelody force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from bb7fd1b to eda96a9 Compare October 6, 2023 09:45

HekkiMelody requested review from Borruso and SirAionTech October 6, 2023 09:46

HekkiMelody marked this pull request as ready for review October 6, 2023 09:47

monen17 and others added 7 commits October 6, 2023 12:06

[10.0][ADD] l10n_it_website_portal_fiscalcode (OCA#867)

4a7c370

porting l10n_it_website_portal_fiscalcode to 12

ec92887

merge PR 1264 1717 1728 1737 1739

4885e52

[IMP] l10n_it_website_portal_fiscalcode: black, isort, prettier

513277a

[MIG] l10n_it_website_portal_fiscalcode: Migration to 14.0

6bc8d79

HekkiMelody force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from eda96a9 to 22f3f7f Compare October 6, 2023 10:06

SirAionTech suggested changes Oct 6, 2023

View reviewed changes

FrancescoBallerini and others added 3 commits October 6, 2023 12:41

14.0 Fix portal fiscalcode label

d3b1519

[IMP] l10n_it_website_portal_fiscalcode: pre-commit stuff

5582081

[MIG] l10n_it_website_portal_fiscalcode: Migration to 16.0

263251c

HekkiMelody force-pushed the 16.0-mig-l10n-it-portal-fiscal-code branch from 22f3f7f to 263251c Compare October 6, 2023 10:42

SirAionTech approved these changes Oct 6, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 6, 2023

OCA-git-bot added the bot is merging ⏳ label Oct 6, 2023

OCA-git-bot added a commit that referenced this pull request Oct 6, 2023

Merge PR #3338 into 16.0

a4e7860

Signed-off-by OpenCode

OCA-git-bot merged commit 0442c9c into OCA:16.0 Oct 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 6, 2023

HekkiMelody deleted the 16.0-mig-l10n-it-portal-fiscal-code branch October 31, 2023 08:38

francesco-ooops added the migration label Jan 10, 2024

	).details_form_validate(data, partner_creattion=partner_creation)
	).details_form_validate(data, partner_creation=partner_creation)

Uh oh!

Conversation

HekkiMelody commented May 30, 2023

Uh oh!

tafaRU commented Jul 6, 2023

Uh oh!

OCA-git-bot commented Jul 6, 2023

Uh oh!

HekkiMelody commented Jul 6, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guidgaro left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati commented Sep 25, 2023

Uh oh!

OCA-git-bot commented Sep 25, 2023

Uh oh!

francesco-ooops commented Sep 25, 2023

Uh oh!

PicchiSeba commented Sep 25, 2023

Uh oh!

TheMule71 commented Sep 25, 2023

Uh oh!

OCA-git-bot commented Sep 25, 2023

Uh oh!

PicchiSeba commented Sep 26, 2023

Uh oh!

FrancescoBallerini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Borruso Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

HekkiMelody commented Oct 6, 2023

Uh oh!

HekkiMelody commented Oct 6, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrancescoBallerini commented Oct 6, 2023

Uh oh!

HekkiMelody commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Borruso Oct 5, 2023 •

edited

Loading

HekkiMelody commented Oct 6, 2023 •

edited

Loading