18.0 mig l10n it central journal reportlab by jado95 · Pull Request #4491 · OCA/l10n-italy

jado95 · 2024-12-06T15:13:28Z

No description provided.

SirAionTech · 2024-12-13T15:01:11Z

/ocabot migration l10n_it_central_journal_reportlab

MaurizioPellegrinet

Manca riferimento del partner, sia su stampa dettagliata che con raggruppamento conti

MarcoCalcagni

LGTM

odooNextev · 2025-03-20T10:26:23Z

Quando viene fatto il merge di questa PR #4530 dovrebbero passare i test

francesco-ooops · 2025-03-27T16:18:25Z

/ocabot rebase

…le stampa reportlab

Currently translated at 88.3% (53 of 60 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_central_journal_reportlab/it/

Currently translated at 95.0% (57 of 60 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_central_journal_reportlab/it/

Currently translated at 100.0% (60 of 60 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_central_journal_reportlab/it/

Currently translated at 100.0% (61 of 61 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_central_journal_reportlab/it/

Currently translated at 100.0% (62 of 62 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_central_journal_reportlab/it/

…pany

…pdate

When extracting a grouped report, if `<` or `>` are in the account_name variable they are interpreted as html tags and an error is raised. This fixes the issue.

OCA-git-bot · 2025-03-27T16:18:36Z

Congratulations, PR rebased to 18.0.

primes2h

#4510

eLBati · 2025-04-10T08:03:53Z

#4510

In chiamata abbiamo valutato che non riusciremmo adesso con le risorse attuali. Lo riteniamo meno prioritario rispetto a rilasciare la funzionalità sulla 18

gdemarco2esseti

Functional Review: Needs fix

Dovrebbe indicare il riferimento al partner e non al numero del documento

monen17

Grazie della PR!
Grande che hai già schiacciato i commit dei bot 👏
Potresti però includere (nel punto corretto della history) gli ultimi commit della 16.0?
Manca ad esempio 7cc8de8 e diverse traduzioni

monen17 · 2025-04-11T09:50:36Z

 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_date_range_group_account_manager,group_account_manager model_date_range,model_date_range,account.group_account_manager,1,1,0,0
-access_wizard_giornale_reportlab_manager,access_wizard_giornale_reportlab manager,l10n_it_central_journal_reportlab.model_wizard_giornale_reportlab,,1,1,1,1
+access_wizard_giornale_reportlab_manager,access_wizard_giornale_reportlab manager,l10n_it_central_journal_reportlab.model_wizard_giornale_reportlab,account.group_account_manager,1,1,1,1


Prima tutti gli utenti avevano questo accesso quindi penso si traduca nell'aggiunta di base.group_user.

Se invece si vuole modificare questo accesso ok, ma va fuori secondo me dallo scope della migrazione di per sé quindi andrebbe come minimo in un commit separato.

In v18 in teoria non è possibile lasciare il gruppo vuoto.
Anche in call su discord abbiam discusso, e avere un gruppo di contabilità che faccia una stampa contabile, è più corretto che avere un qualsiasi utente che possa farlo

monen17 · 2025-04-11T09:56:20Z


-    <record id="view_date_range_inherit_tree" model="ir.ui.view">
-        <field name="name">date.range.tree.inherit</field>
+    <record id="view_date_range_inherit_list" model="ir.ui.view">


Capisco mantenere la coerenza con il tipo di vista, ma per cambiare l'XMLID serve anche una migrazione (vedi https://oca.github.io/openupgradelib/API.html#openupgradelib.openupgrade.rename_xmlids), altrimenti eventuali viste dipendenti potrebbero non trovarlo più.

La soluzione più veloce invece è lasciarlo com'era 😉

monen17 · 2025-04-11T10:01:42Z

-        self, move_line_ids, tables, start_row, width_available
+        self, list_line_not_grouped, tables, start_row, width_available


Questa come diverse altre modifiche non mi sembrano proprie di una migrazione, potresti chiarire a cosa servono?
Se non servono per la migrazione andrebbero almeno in un commit separato.

Questa dovrebbe semplicemente chiamare l'arg in modo più chiaro, così come fatto per il metodo grupped

…eivable/payable accounts, otherwise use entry name

gdemarco2esseti

Test funzionale: OK

MaurizioPellegrinet

Test funzionale: OK

odooNextev

LGTM

eLBati · 2025-05-23T08:03:15Z

Risolti gli ultimi punti aperti

/ocabot merge nobump

OCA-git-bot · 2025-05-23T08:03:23Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-4491-by-eLBati-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-23T08:10:53Z

Congratulations, your PR was merged at cf9ab3d. Thanks a lot for contributing to OCA. ❤️

francesco-ooops added 18.0 migration labels Dec 9, 2024

SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Dec 9, 2024

OCA-git-bot added this to the 18.0 milestone Dec 13, 2024

OCA-git-bot mentioned this pull request Dec 13, 2024

Migration to version 18.0 #4392

Open

46 tasks

jado95 force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch 3 times, most recently from daf91c2 to 455372c Compare December 13, 2024 16:35

SirAionTech removed the needs fixing Has conflicts or is failing mandatory CI checks label Dec 18, 2024

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Dec 23, 2024

[ADD] l10n_it_central_journal_reportlab: aggiunta PR OCA#4491

18aee88

primes2h linked an issue Jan 19, 2025 that may be closed by this pull request

Terminologia inglese utilizzata non corrisponde alle funzionalità esistenti ed è fuorviante #4510

Open

1 task

Borruso mentioned this pull request Jan 24, 2025

PR aggiunte v18 DinamicheAziendali/l10n-italy#2

Open

10 tasks

MaurizioPellegrinet suggested changes Jan 31, 2025

View reviewed changes

jado95 force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch from 455372c to 16710b6 Compare January 31, 2025 16:02

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jan 31, 2025

[UPD] l10n_it_central_journal_reportlab: aggiunta PR OCA#4491

1038c3b

jado95 force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch 2 times, most recently from f3bf5e3 to eb3d9e2 Compare February 7, 2025 14:13

MarcoCalcagni approved these changes Feb 14, 2025

View reviewed changes

jado95 force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch from eb3d9e2 to 1d94d49 Compare February 14, 2025 11:13

jado95 force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch from 1d94d49 to 17e6a01 Compare February 28, 2025 16:57

primes2h mentioned this pull request Mar 26, 2025

Terminologia inglese utilizzata non corrisponde alle funzionalità esistenti ed è fuorviante #4510

Open

1 task

Borruso and others added 6 commits March 27, 2025 16:18

[ADD] l10n_it_central_journal_reportlab: aggiunto modulo libro giorna…

78210f4

…le stampa reportlab

Added translation using Weblate (Italian)

5f1f48a

[MIG] l10n_it_central_journal_reportlab: Migration to 16.0

fd0802b

mymage and others added 11 commits March 27, 2025 16:18

[FIX] l10n_it_central_journal_reportlab: fix nolabel view

4daac22

[FIX] l10n_it_central_journal_reportlab: fix print giornale multi-com…

94df5fb

…pany

Updated from template

e9424c9

[REF] l10n_it_central_journal_reportlab: Reformatted after template u…

4bcf03e

…pdate

[FIX] l10n_it_central_journal_reportlab account_name formatting error

23a0953

When extracting a grouped report, if `<` or `>` are in the account_name variable they are interpreted as html tags and an error is raised. This fixes the issue.

[FIX] l10n_it_central_journal_reportlab: Support lines without account

f98a422

[FIX] l10n_it_central_journal_reportlab: escape Paragraph content

32957c9

[IMP] l10n_it_central_journal_reportlab: pre-commit auto fixes

fd883c7

[MIG] l10n_it_central_journal_reportlab: Migration to 18.0

94af281

OCA-git-bot force-pushed the 18.0-MIG-l10n_it_central_journal_reportlab branch from 17e6a01 to 94af281 Compare March 27, 2025 16:18

primes2h requested changes Mar 27, 2025

View reviewed changes

gdemarco2esseti reviewed Apr 10, 2025

View reviewed changes

monen17 requested changes Apr 11, 2025

View reviewed changes

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Apr 18, 2025

[UPD] l10n_it_central_journal_reportlab: aggiornato PR OCA#4491

72b157d

[MIG] l10n_it_central_journal_reportlab: Display partner name for rec…

e26fef1

…eivable/payable accounts, otherwise use entry name

gdemarco2esseti approved these changes May 16, 2025

View reviewed changes

MaurizioPellegrinet approved these changes May 16, 2025

View reviewed changes

[FIX] l10n_it_central_journal_reportlab style and view

b4b9fd7

odooNextev approved these changes May 23, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 23, 2025

OCA-git-bot merged commit 274459d into OCA:18.0 May 23, 2025
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 23, 2025

		self, move_line_ids, tables, start_row, width_available
		self, list_line_not_grouped, tables, start_row, width_available

Uh oh!

Conversation

jado95 commented Dec 6, 2024

Uh oh!

SirAionTech commented Dec 13, 2024

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

MarcoCalcagni left a comment

Choose a reason for hiding this comment

Uh oh!

odooNextev commented Mar 20, 2025

Uh oh!

francesco-ooops commented Mar 27, 2025

Uh oh!

OCA-git-bot commented Mar 27, 2025

Uh oh!

primes2h left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati commented Apr 10, 2025

Uh oh!

gdemarco2esseti left a comment

Choose a reason for hiding this comment

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

monen17 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

jado95 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

jado95 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

gdemarco2esseti left a comment

Choose a reason for hiding this comment

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati commented May 23, 2025

Uh oh!

OCA-git-bot commented May 23, 2025

Uh oh!

OCA-git-bot commented May 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants