[18.0] [MIG] l10n_it_vat_registries by odooNextev · Pull Request #4664 · OCA/l10n-italy

odooNextev · 2025-03-20T20:35:26Z

No description provided.

eLBati · 2025-03-21T08:49:58Z

/ocabot migration l10n_it_vat_registries

l10n_it_appointment_code: OCA#4665 l10n_it_vat_registries: OCA#4664 l10n_it_vat_statement_communication: OCA#4676

eLBati · 2025-04-03T09:27:12Z

/ocabot rebase

OCA-git-bot · 2025-04-03T09:27:19Z

Congratulations, PR rebased to 18.0.

eLBati · 2025-04-10T13:29:52Z

/ocabot rebase

OCA-git-bot · 2025-04-10T13:30:00Z

Congratulations, PR rebased to 18.0.

eLBati · 2025-04-10T13:35:04Z

@@ -0,0 +1 @@
+odoo-addon-l10n_it_account @ git+https://github.com/OCA/l10n-italy.git@refs/pull/4555/head#subdirectory=l10n_it_account


merged, si può togliere

Test passati dopo aver fatto il FW del commit per rimuovere cee_type

eLBati · 2025-04-10T13:42:50Z

/ocabot rebase

OCA-git-bot · 2025-04-10T13:42:58Z

Congratulations, PR rebased to 18.0.

eLBati · 2025-04-10T14:08:06Z

/ocabot rebase

OCA-git-bot · 2025-04-10T14:08:15Z

Congratulations, PR rebased to 18.0.

MaurizioPellegrinet

Test funzionale: OK

monen17

Oltre alle cose scritte sotto, i messaggi di alcuni commit andrebbero tradotti in inglese per https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message:

Commit messages are in English

Ci sono ancora dei commit in italiano, sono da scrivere in inglese:

monen17 · 2025-05-02T08:40:29Z

+        for tax in self:
+            accounts = tax._get_accounts_tax()
+            accounts = accounts.filtered(
+                lambda a: a.account_type.startswith("liability")


Qui e nell'altro startswith, penso sia meglio indicare esplicitamente quali sono i tipi di conto da considerare come debito/credito, come viene fatto ad esempio per i tipi di registrazioni contabili in https://github.com/odoo/odoo/blob/44e61c6b429aab94e4656ade5e0f0275b905210a/addons/account/models/account_move.py#L5524-L5533.

monen17 · 2025-05-02T08:54:54Z

+            debit_balance = -debit_balance
+            credit_balance = -credit_balance
+        if registry_type == "customer" and tax.type_tax_use == "purchase":
+            # caso reverse charge in regsitro IVA vendite


I commenti, come i messaggi dei commit, devono essere in inglese, vedi https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#33idioms:

Use English variable names and write comments in English.

monen17 · 2025-05-02T08:56:07Z

+            debit_balance,
+            credit_balance,


Allora queste modifiche dovrebbero essere nel commit di migrazione.

eLBati · 2025-05-09T07:14:28Z

i messaggi di alcuni commit andrebbero tradotti in inglese

fatto

…en taxes

Currently translated at 28.5% (18 of 63 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_vat_registries/de/

monen17

Grazie delle modifiche!
C'è solo una modifica al codice che non mi torna: quella delle children_tax_ids, per il resto sono problemi di commit.

Per i problemi di commit, la struttura ideale:

Modifiche a l10n_it_account in una PR separata
In questa PR:
1. Tutti i commit della 16.0 + pre-commit per la migrazione
2. Commit dovuti alla migrazione di l10n_it_vat_registries

Visto però che questa struttura non si riesce ad applicare perché ci sono commit applicati prima/dopo, autori diversi ecc. possiamo anche lasciare tutto in questa PR con questa struttura:

Modifiche a l10n_it_account
Tutti i commit della 16.0 + pre-commit per la migrazione
Commit dovuti alla migrazione di l10n_it_vat_registries
Commit di 16.0 che sono stati applicati dopo la migrazione, e che non si riescono a mettere nel punto giusto della storia
Eventuali altri commit dovuti alla migrazione di l10n_it_vat_registries se non si riescono a schiacciare nel commit di migrazione, che però almeno inizino con [MIG].

Se devi unire commit di autori diversi, mettiti come co-autore (vedi https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors).

monen17 · 2025-05-09T11:05:20Z


        tax = self.env["account.tax"].with_context(**context).browse(self.id)
        tax_name = tax._get_tax_name()
-        if not tax.children_tax_ids:


Non lo stiamo già facendo in questa PR il porting del modulo?
Se è un miglioramento, andrebbe riportato anche per le altre versioni?

monen17 · 2025-05-09T11:11:14Z

+    include_rc_moves = fields.Boolean(
+        string="Include reverse charge moves",
+    )


Allora andrebbe nel commit di migrazione

@monen17 però il commit di migrazione ha un altro autore

O ti metti come co-autore e teniamo un solo commit di migrazione (secondo me meglio), oppure lo lasci in un commit separato, ma almeno che inizi con [MIG].

monen17 · 2025-05-09T11:16:38Z

+<div class="section" id="other-credits">
+<h2><a class="toc-backref" href="#toc-entry-7">Other credits</a></h2>
+<p>The development of this module has been financially supported by:</p>
+<ul class="simple">
+<li>Odoo Italia Network</li>
+<li>APS Odoo Italia</li>
+</ul>
+</div>


Questo andrebbe nel commit in cui ha ripristinato il file CREDITS.

monen17 · 2025-05-09T11:29:13Z

+            debit_balance,
+            credit_balance,


Non avevo notato che queste sono modifiche a l10n_it_account, quindi va bene lasciarle come IMP del modulo l10n_it_account.

A quanto ho capito questa nuova feature di l10n_it_account serve a far funzionare correttamente i registri IVA nella 18.0, quindi andrebbe in una PR a parte da mergiare prima della migrazione.
In questo modo si eviterebbero problemi di dipendenza tra varie PR di migrazione (mi scrivevi che la #4675 dipende da questa PR proprio a causa di queste fix).

Mi scrivevi però che ti complica la fase di sviluppo, quindi va bene lasciarlo qui, alla fine per quanto riguarda la storia dei commit è solo importante che sia in un commit separato.
Riesci però a spostarlo prima di tutti i commit di migrazione? Così dovresti anche riuscire a unire 6678fe8 e 5ac3c02 come suggerivo in #4664 (comment).

monen17 · 2025-05-09T11:37:12Z

-The development of this module has been financially supported by:
-
- Odoo Italia Network


Grazie, però hai ripristinato il file in un commit e rigenerato il README in un altro, puoi farlo nello stesso commit?

- show debit/credit tax totals for reverse charge operations - include reverse charge documents in sales VAT registry

eLBati · 2025-05-09T12:37:10Z

#4664 (comment) forse sì ma meglio fare così ora, lasciare indietro le altre versioni e andare avanti

eLBati · 2025-05-09T12:40:19Z

/ocabot merge nobump

OCA-git-bot · 2025-05-09T12:40:27Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-4664-by-eLBati-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-09T12:47:31Z

Congratulations, your PR was merged at b47e0c9. Thanks a lot for contributing to OCA. ❤️

stenext force-pushed the 18.0-mig-l10n_it_vat_registries branch 4 times, most recently from d244386 to b5f6f21 Compare March 20, 2025 20:49

OCA-git-bot added this to the 18.0 milestone Mar 21, 2025

OCA-git-bot mentioned this pull request Mar 21, 2025

Migration to version 18.0 #4392

Open

46 tasks

jado95 added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Mar 28, 2025

ADD PR: account_vat_period_end_statement: OCA#4675

498c83d

l10n_it_appointment_code: OCA#4665 l10n_it_vat_registries: OCA#4664 l10n_it_vat_statement_communication: OCA#4676

jado95 mentioned this pull request Mar 28, 2025

PR aggiunte v18 DinamicheAziendali/l10n-italy#2

Open

10 tasks

OCA-git-bot force-pushed the 18.0-mig-l10n_it_vat_registries branch from b5f6f21 to 3192df1 Compare April 3, 2025 09:27

OCA-git-bot force-pushed the 18.0-mig-l10n_it_vat_registries branch from 3192df1 to 809dbad Compare April 10, 2025 13:30

eLBati requested changes Apr 10, 2025

View reviewed changes

stenext force-pushed the 18.0-mig-l10n_it_vat_registries branch from 809dbad to b13a712 Compare April 10, 2025 13:39

odooNextev requested a review from eLBati April 10, 2025 13:39

OCA-git-bot force-pushed the 18.0-mig-l10n_it_vat_registries branch from b13a712 to b7fd18c Compare April 10, 2025 13:42

stenext force-pushed the 18.0-mig-l10n_it_vat_registries branch from b7fd18c to 1e6f42a Compare April 10, 2025 13:51

OCA-git-bot force-pushed the 18.0-mig-l10n_it_vat_registries branch from 1e6f42a to a0ee9b4 Compare April 10, 2025 14:08

francesco-ooops added 18.0 migration labels Apr 14, 2025

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Apr 18, 2025

[UPD] l10n_it_vat_registries: aggiornato PR OCA#4664

8e49233

eLBati force-pushed the 18.0-mig-l10n_it_vat_registries branch 2 times, most recently from 580b962 to 7482d26 Compare April 18, 2025 14:47

MaurizioPellegrinet approved these changes May 2, 2025

View reviewed changes

monen17 requested changes May 2, 2025

View reviewed changes

eLBati force-pushed the 18.0-mig-l10n_it_vat_registries branch from ca38b76 to d52a13f Compare May 9, 2025 07:14

odooNextev and others added 4 commits May 9, 2025 09:21

[MIG] l10n_it_vat_registries: Migration to 18.0

5ac3c02

l10n_it_vat_registries: REF removing cee_type

50176fd

IMP l10n_it_account: _compute_totals_tax not called anymore on childr…

7c44d38

…en taxes

Translated using Weblate (German)

1300878

Currently translated at 28.5% (18 of 63 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_vat_registries/de/

eLBati force-pushed the 18.0-mig-l10n_it_vat_registries branch 6 times, most recently from 30910a1 to 94309fb Compare May 9, 2025 09:15

IMP l10n_it_account: add debit_balance and credit_balance to account.tax

f5136a5

eLBati force-pushed the 18.0-mig-l10n_it_vat_registries branch from 94309fb to 6678fe8 Compare May 9, 2025 09:27

monen17 self-requested a review May 9, 2025 10:49

monen17 requested changes May 9, 2025

View reviewed changes

[MIG] REF l10n_it_vat_registries for reverse charge v18:

61d64fc

- show debit/credit tax totals for reverse charge operations - include reverse charge documents in sales VAT registry

eLBati force-pushed the 18.0-mig-l10n_it_vat_registries branch from 6678fe8 to 61d64fc Compare May 9, 2025 12:32

OCA-git-bot added the bot is merging ⏳ label May 9, 2025

OCA-git-bot merged commit 38ff9d6 into OCA:18.0 May 9, 2025
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 9, 2025

monen17 mentioned this pull request May 9, 2025

Vari moduli account - removing cee_type #4697

Closed

3 tasks

monen17 mentioned this pull request Mar 23, 2026

[18.0] [FIX] l10n_it_vat_registries: allow to set rc_journal_ids #5024

Open

		@@ -0,0 +1 @@
		odoo-addon-l10n_it_account @ git+https://github.com/OCA/l10n-italy.git@refs/pull/4555/head#subdirectory=l10n_it_account

		The development of this module has been financially supported by:

		- Odoo Italia Network

Uh oh!

Conversation

odooNextev commented Mar 20, 2025

Uh oh!

eLBati commented Mar 21, 2025

Uh oh!

eLBati commented Apr 3, 2025

Uh oh!

OCA-git-bot commented Apr 3, 2025

Uh oh!

eLBati commented Apr 10, 2025

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented Apr 10, 2025

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

eLBati commented Apr 10, 2025

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented May 9, 2025

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

monen17 May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented May 9, 2025

Uh oh!

eLBati commented May 9, 2025

Uh oh!

OCA-git-bot commented May 9, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 9, 2025

monen17 May 9, 2025 •

edited

Loading