Skip to content

[18.0] [MIG] l10n_it_appointment_code#4665

Merged
OCA-git-bot merged 5 commits into
OCA:18.0from
odooNextev:18.0-mig-l10n_it_appointment_code
Apr 10, 2025
Merged

[18.0] [MIG] l10n_it_appointment_code#4665
OCA-git-bot merged 5 commits into
OCA:18.0from
odooNextev:18.0-mig-l10n_it_appointment_code

Conversation

@odooNextev

@odooNextev odooNextev commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@odooNextev odooNextev mentioned this pull request Mar 21, 2025
Open
46 tasks
@francesco-ooops

francesco-ooops commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_it_appointment_code

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 26, 2025
@stenext stenext force-pushed the 18.0-mig-l10n_it_appointment_code branch from e2ef41c to ee73400 Compare March 26, 2025 13:30
jado95 added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Mar 28, 2025
@jado95
ADD PR: account_vat_period_end_statement: OCA#4675
498c83d 
l10n_it_appointment_code: OCA#4665
l10n_it_vat_registries: OCA#4664
l10n_it_vat_statement_communication: OCA#4676
@jado95 jado95 mentioned this pull request Mar 28, 2025
Open
10 tasks
monen17
monen17 requested changes Apr 4, 2025
View reviewed changes

@monen17 monen17 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto revisione del codice e provato il modulo, per me è ok.

Ho anche controllato la storia dei commmit e sono fedeli a quelli di 16.0, potresti però schiacciare i commit dei bot come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

Comment thread l10n_it_appointment_code/models/appointment_code.py Outdated
Comment on lines +21 to +22
self.env._("The element with code %s already exists")
% appointment_code.code

@monen17 monen17 Apr 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giusto! Questo è una bella novità della 18.0, potremmo anche approfittarne per usare la struttura

self.env._("hello %s", "test")

che ne dici?

@odooNextev odooNextev Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatto

@stenext stenext force-pushed the 18.0-mig-l10n_it_appointment_code branch from ee73400 to b61fd2a Compare April 7, 2025 08:57
francesco-ooops
francesco-ooops reviewed Apr 7, 2025
View reviewed changes
Comment thread l10n_it_appointment_code/readme/USAGE.md Outdated

Installando il modulo vengono precaricati i codici disponibili. È
possibile aggiungere nuovi codici o modificare quelli esistenti. Non è
possibile avere più di un elemento con lo stesso codice.

@francesco-ooops francesco-ooops Apr 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odooNextev Usage dovrebbe dare indicazioni funzionali sull'uso del modulo, si può aggiungere semplicemente da dove si accede a questi codici?

@odooNextev odooNextev Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto

@stenext stenext force-pushed the 18.0-mig-l10n_it_appointment_code branch 2 times, most recently from 05c2b07 to e9bf2ae Compare April 7, 2025 12:23
@tafaRU

tafaRU commented Apr 10, 2025

Copy link
Copy Markdown
Member

@francesco-ooops puoi aggiornare la tua review?

@tafaRU

tafaRU commented Apr 10, 2025

Copy link
Copy Markdown
Member

@francesco-ooops in realtà, noto solo ora, che non avevi ancora fatto review ma avevi semplicemente commentato 😉

@tafaRU

tafaRU commented Apr 10, 2025

Copy link
Copy Markdown
Member

@odooNextev eseguo /ocabot rebase perché non vedo runboat.

@OCA-git-bot

OCA-git-bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Hi @tafaRU. Your command failed:

Invalid options for command rebase: perché non vedo.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@tafaRU

tafaRU commented Apr 10, 2025

Copy link
Copy Markdown
Member

/ocabot rebase

tafaRU and others added 5 commits April 10, 2025 08:26
@tafaRU @OCA-git-bot
Rename module to l10n_it_appointment_code
58d5db1 
Rename cannot be perfomed with hook as OCA#2220 (comment)
Also note:

* merge_modules = True is not needed when we simply rename modules
* rename_xmlids has to be executed as first to build menus_by_module properly otherwise we get:
test-l10n_it_codici_carica=# select id ,name, menus_by_module from ir_module_module where name like '%appointment%';
 id  |           name           |                   menus_by_module
-----+--------------------------+------------------------------------------------------
 488 | l10n_it_appointment_code | Invoicing/Configuration/Accounting/Appointment Codes+
     |                          | Invoicing/Configuration/Accounting/Role Codes

[UPD] Update l10n_it_appointment_code.pot

[UPD] README.rst
@Borruso @OCA-git-bot
[MIG] l10n_it_appointment_code: Migration to 16.0
321f85c
@SirAionTech @OCA-git-bot
Updated from template
e95b60d
@odooNextev @OCA-git-bot
[IMP] l10n_it_appointment_code: pre-commit auto fixes
e58f3af
@odooNextev @OCA-git-bot
[MIG] l10n_it_appointment_code: Migration to 18.0
d44cc8e
@OCA-git-bot

OCA-git-bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Congratulations, PR rebased to 18.0.

@OCA-git-bot OCA-git-bot force-pushed the 18.0-mig-l10n_it_appointment_code branch from e9bf2ae to d44cc8e Compare April 10, 2025 08:26
tafaRU
tafaRU approved these changes Apr 10, 2025
View reviewed changes

@tafaRU tafaRU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testata anche su runboat 👍

@eLBati

eLBati commented Apr 10, 2025

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-4665-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2a1cc41 into OCA:18.0 Apr 10, 2025
@OCA-git-bot

OCA-git-bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c4532b4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tafaRU tafaRU tafaRU approved these changes

@francesco-ooops francesco-ooops Awaiting requested review from francesco-ooops

@monen17 monen17 Awaiting requested review from monen17

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

8 participants

@odooNextev @francesco-ooops @tafaRU @OCA-git-bot @eLBati @monen17 @Borruso @SirAionTech
⚡