chore: place init_flash after init_core#612
Closed
NewPaulWalker wants to merge 1 commit intomasterfrom
Closed
Conversation
First, this does not introduce any functional changes. Second, the reason for this modification is that with the introduction of OpenXiangShan/XiangShan#4626, the simulation output includes some less elegant messages: Using simulated 32768B flash Core 0's Commit SHA is: 6683fc49ec, dirty: 1 Using simulated 8386560MB RAM This change makes the output look better.
poemonsense
reviewed
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, this does not introduce any functional changes.
Second, the reason for this modification is that with the introduction of OpenXiangShan/XiangShan#4626, the simulation output includes some less elegant messages:
This change makes the output look better.