Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

fixes #1380 by temporarily pinning a core-js to a specific beta version.#1381

Closed
mikeshultz wants to merge 1 commit intomasterfrom
core-js-error
Closed

fixes #1380 by temporarily pinning a core-js to a specific beta version.#1381
mikeshultz wants to merge 1 commit intomasterfrom
core-js-error

Conversation

@mikeshultz
Copy link
Copy Markdown
Contributor

Description:

apollo-tooling is running with a beta dep that has an evolving API. Some imports changed on them and they didn't pin a specific version. I'm not a huge fan of this PR, since a fix is on the way. So this is temporary and should be removed once it's fixed by our dependency. This does allow tests to run as expected, however, and it's unclear if this may cause issues in production.

References

apollographql/apollo-tooling#962
apollographql/apollo-tooling#961

Checklist:

  • Test your work and double-check to confirm that you didn't break anything
  • Wrap any displayed ETH addresses with formattedAddress
  • Wrap any new text/strings for translation
  • Run npm run translations if there are any changes to translated strings
  • Map any new environment variables with a default value in the Webpack config
  • Update any relevant READMEs and docs

@mikeshultz mikeshultz added bug Something isn't working as intended graphql labels Feb 2, 2019
@mikeshultz mikeshultz self-assigned this Feb 2, 2019
@mikeshultz
Copy link
Copy Markdown
Contributor Author

Closing this. They fixed their release.

apollographql/apollo-tooling#961 (comment)

@mikeshultz mikeshultz closed this Feb 3, 2019
@mikeshultz mikeshultz deleted the core-js-error branch February 3, 2019 04:24
@franckc
Copy link
Copy Markdown
Contributor

franckc commented Feb 3, 2019

Thanks in any case @mikeshultz for investigating ! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working as intended graphql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants