This repository was archived by the owner on Sep 20, 2023. It is now read-only.
fixes #1380 by temporarily pinning a core-js to a specific beta version.#1381
Closed
mikeshultz wants to merge 1 commit intomasterfrom
Closed
fixes #1380 by temporarily pinning a core-js to a specific beta version.#1381mikeshultz wants to merge 1 commit intomasterfrom
mikeshultz wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
Closing this. They fixed their release. |
Contributor
|
Thanks in any case @mikeshultz for investigating ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
apollo-toolingis running with a beta dep that has an evolving API. Some imports changed on them and they didn't pin a specific version. I'm not a huge fan of this PR, since a fix is on the way. So this is temporary and should be removed once it's fixed by our dependency. This does allow tests to run as expected, however, and it's unclear if this may cause issues in production.References
apollographql/apollo-tooling#962
apollographql/apollo-tooling#961
Checklist:
formattedAddressnpm run translationsif there are any changes to translated strings