Pin core-js version in apollo-env#961
Merged
JakeDawkins merged 1 commit intoapollographql:masterfrom Feb 3, 2019
Merged
Conversation
The API was changed in 3.0.0-beta.12. `core-js/proposals/array-flat-and-flat-map` was removed.
|
@bfirsh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
stevefan1999-personal
left a comment
There was a problem hiding this comment.
I think we could fallback to one version before 12 -- 3.0.0-beta.11 in specific
4 tasks
Contributor
|
We can assume that the moved dependencies will not move back, so I think it's a good idea to pin to the current latest beta, but also update the imports. Using diff --git a/node_modules/apollo-env/lib/polyfills/array.js b/node_modules/apollo-env/lib/polyfills/array.js
index 9d5bb1f..7dc6721 100644
--- a/node_modules/apollo-env/lib/polyfills/array.js
+++ b/node_modules/apollo-env/lib/polyfills/array.js
@@ -1,4 +1,5 @@
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
-require("core-js/proposals/array-flat-and-flat-map");
+require("core-js/es/array/flat");
+require("core-js/es/array/flat-map");
//# sourceMappingURL=array.js.map
diff --git a/node_modules/apollo-env/lib/polyfills/object.js b/node_modules/apollo-env/lib/polyfills/object.js
index f302992..c215afb 100644
--- a/node_modules/apollo-env/lib/polyfills/object.js
+++ b/node_modules/apollo-env/lib/polyfills/object.js
@@ -1,4 +1,4 @@
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
-require("core-js/proposals/object-from-entries");
+require("core-js/es/object/from-entries");
//# sourceMappingURL=object.js.map |
This was referenced Feb 2, 2019
JakeDawkins
approved these changes
Feb 3, 2019
Contributor
|
Thanks so much for this @bfirsh I'll publish this now |
Contributor
|
Released in |
12 tasks
nellh
added a commit
to OpenNeuroOrg/openneuro
that referenced
this pull request
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API was changed in 3.0.0-beta.12 (released 2 hours ago) causing this error in my application:
It seems sensible to pin to a specific beta version while the API is moving around. When 3.0.0 is released, then it could be switched back to
^3.0.0.