Skip to content

Update package.json#1263

Closed
siddharth90 wants to merge 2 commits intoapollographql:masterfrom
siddharth90:patch-1
Closed

Update package.json#1263
siddharth90 wants to merge 2 commits intoapollographql:masterfrom
siddharth90:patch-1

Conversation

@siddharth90
Copy link
Copy Markdown

@siddharth90 siddharth90 commented May 13, 2019

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link
Copy Markdown

@siddharth90: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@trevor-scheer
Copy link
Copy Markdown
Contributor

Hey @siddharth90, thanks for the PR! This change is slightly more nuanced than just a version update in the package file, so I've opened this PR #1267.

We had an issue in the past with an update that broke things for us, requiring us to pin the version indefinitely: #961

But since you've raised my awareness to the official 3.x (stable) release, we can clean things up a bit on our side 😄

@siddharth90
Copy link
Copy Markdown
Author

Thanks for taking it into consideration and making the PR trevor! :)
Yes we were facing security issues as that particular version had a dependency on some other module version and it was flagged for security risk. Hence i looked up and saw they have a beta version that we could use now. I was sure there shouldve been a reason you had pinned the version to beta before. But thanks for taking this up now !

@siddharth90 siddharth90 deleted the patch-1 branch May 20, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants