Skip to content

packages: apollo-env: use core-js@3.0.0-beta.3 only#963

Closed
xdevs23 wants to merge 1 commit intoapollographql:masterfrom
xdevs23:patch-1
Closed

packages: apollo-env: use core-js@3.0.0-beta.3 only#963
xdevs23 wants to merge 1 commit intoapollographql:masterfrom
xdevs23:patch-1

Conversation

@xdevs23
Copy link
Copy Markdown

@xdevs23 xdevs23 commented Feb 2, 2019

In the latest version (that is core-js@3.0.0-beta.13 or
core-js@2.6.3 at the point of writing this) the path for
array-flat-and-flat-map changed.

core-js/proposals/array-flat-and-flat-map is no longer accessible
and thus causes errors for anyone using this package, for example
@vue/cli.

Test: yarn add core-js@3.0.0-beta.3, works now

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

In the latest version (that is core-js@3.0.0-beta.13 or
core-js@2.6.3 at the point of writing this) the path for
`array-flat-and-flat-map` changed.

core-js/proposals/array-flat-and-flat-map is no longer accessible
and thus causes errors for anyone using this package, for example
@vue/cli.

Test: `yarn add core-js@3.0.0-beta.3`, works now
@apollo-cla
Copy link
Copy Markdown

@xdevs23: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@xdevs23
Copy link
Copy Markdown
Author

xdevs23 commented Feb 2, 2019

Looks like I looked too late, duplicate is #961

@xdevs23 xdevs23 closed this Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants